From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbdLDSbd (ORCPT ); Mon, 4 Dec 2017 13:31:33 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59874 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750854AbdLDSbc (ORCPT ); Mon, 4 Dec 2017 13:31:32 -0500 Date: Mon, 4 Dec 2017 10:31:27 -0800 From: "Paul E. McKenney" To: Lai Jiangshan Cc: LKML , Ingo Molnar , dipankar@in.ibm.com, akpm@linux-foundation.org, Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , oleg@redhat.com Subject: Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK Reply-To: paulmck@linux.vnet.ibm.com References: <20171201194139.GA22722@linux.vnet.ibm.com> <1512157320-23205-2-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17120418-0052-0000-0000-0000028C5B0A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008152; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000243; SDB=6.00955403; UDB=6.00482865; IPR=6.00735441; BA=6.00005727; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018343; XFM=3.00000015; UTC=2017-12-04 18:31:28 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120418-0053-0000-0000-000052D0A738 Message-Id: <20171204183127.GA7829@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-04_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040262 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 02, 2017 at 09:27:46AM +0800, Lai Jiangshan wrote: > On Sat, Dec 2, 2017 at 3:41 AM, Paul E. McKenney > wrote: > > This commit changes the %p printk() in rcutorture to %pK. This could > > be considered irrelevant, given that any user able to start rcutorture > > could inflict far heavier damage on the system, but it doesn't hurt to > > change it and doing so avoids script-generated noise. > > > > Reported-by: Tobin C. Harding > > Signed-off-by: Paul E. McKenney > > Reviewed-by: Lai Jiangshan Applied, thank you for the review! Thanx, Paul > > --- > > kernel/rcu/srcutree.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c > > index d5cea81378cc..81f2eb78c504 100644 > > --- a/kernel/rcu/srcutree.c > > +++ b/kernel/rcu/srcutree.c > > @@ -386,7 +386,7 @@ void cleanup_srcu_struct(struct srcu_struct *sp) > > flush_delayed_work(&per_cpu_ptr(sp->sda, cpu)->work); > > if (WARN_ON(rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)) != SRCU_STATE_IDLE) || > > WARN_ON(srcu_readers_active(sp))) { > > - pr_info("cleanup_srcu_struct: Active srcu_struct %p state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq))); > > + pr_info("cleanup_srcu_struct: Active srcu_struct %pK state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq))); > > return; /* Caller forgot to stop doing call_srcu()? */ > > } > > free_percpu(sp->sda); > > -- > > 2.5.2 > > >