From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLubG-0001vv-Jv for qemu-devel@nongnu.org; Mon, 04 Dec 2017 12:32:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLubB-0007Ub-LE for qemu-devel@nongnu.org; Mon, 04 Dec 2017 12:32:14 -0500 Date: Mon, 4 Dec 2017 18:32:00 +0100 From: Cornelia Huck Message-ID: <20171204183200.2641e1e2.cohuck@redhat.com> In-Reply-To: <1a964f3a-c5e4-5ad5-fa44-d9242124c955@redhat.com> References: <20171204140150.20483-1-david@redhat.com> <20171204140150.20483-5-david@redhat.com> <20171204182454.5e397739.cohuck@redhat.com> <1a964f3a-c5e4-5ad5-fa44-d9242124c955@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 for-2.12 4/9] s390x/tcg: wire up SET CHANNEL MONITOR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Christian Borntraeger , Richard Henderson , Alexander Graf , Thomas Huth On Mon, 4 Dec 2017 18:27:55 +0100 David Hildenbrand wrote: > On 04.12.2017 18:24, Cornelia Huck wrote: > > On Mon, 4 Dec 2017 15:01:45 +0100 > > David Hildenbrand wrote: > > > >> Let's just wire it up like KVM. > >> > >> Signed-off-by: David Hildenbrand > >> --- > >> target/s390x/helper.h | 1 + > >> target/s390x/insn-data.def | 1 + > >> target/s390x/misc_helper.c | 9 +++++++++ > >> target/s390x/translate.c | 7 +++++++ > >> 4 files changed, 18 insertions(+) > > > > So we would have generated an exception before if someone tried to > > enable channel measurements under tcg? > > > > Yes, PGM_OPERATION should have been triggered. > Next question: What happens now if we try to enable channel measurements? :)