From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH rfc 2/2] nvmet: expose option to emulate a nvm subsystem in read-only mode
Date: Mon, 4 Dec 2017 21:06:53 +0100 [thread overview]
Message-ID: <20171204200653.GA17023@lst.de> (raw)
In-Reply-To: <c3d78077-b5b0-c05e-fca1-ca9ef5a0e1eb@grimberg.me>
On Mon, Dec 04, 2017@08:11:14PM +0200, Sagi Grimberg wrote:
> Can you please elaborate what you mean? are you talking about this
> patch in particular (simply an emulation)? or support for this
> altogether? A subsystem can, at any point, be placed in read-only mode.
> In that case it needs to send SMART AER to indicate health status
> change. I think that if the media has been placed in read-only mode, we
> need to log it, and set all the subsystem namespaces in read-only mode.
>
> Anything different you think we need to do here?
Yes, but for that we should trigger it off gettind a EROFS warning
from the block device, not through sysfs. Having the explicit sysfs
no, and the code to send the AER on connect suggests to me that
this was intended to be used to emulate a r/o setting, but apparently
I was wrong.
next prev parent reply other threads:[~2017-12-04 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 9:24 [PATCH rfc 0/2] Support read-only subsystem critical warning Sagi Grimberg
2017-12-04 9:24 ` [PATCH rfc 1/2] nvme: support smart read-only critical warning event Sagi Grimberg
2017-12-04 20:07 ` Christoph Hellwig
2017-12-05 7:28 ` Sagi Grimberg
2017-12-05 7:57 ` Johannes Thumshirn
2017-12-06 22:47 ` Christoph Hellwig
2017-12-07 6:45 ` Sagi Grimberg
2017-12-04 9:24 ` [PATCH rfc 2/2] nvmet: expose option to emulate a nvm subsystem in read-only mode Sagi Grimberg
2017-12-04 16:19 ` Christoph Hellwig
2017-12-04 18:11 ` Sagi Grimberg
2017-12-04 20:06 ` Christoph Hellwig [this message]
2017-12-05 7:22 ` Sagi Grimberg
2017-12-06 22:46 ` Christoph Hellwig
2017-12-07 6:41 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204200653.GA17023@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.