From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v3 1/5] travis: Add build script and use it in travis
Date: Mon, 4 Dec 2017 21:49:49 +0100 [thread overview]
Message-ID: <20171204204949.GA7318@x230> (raw)
In-Reply-To: <20171204171510.GE21055@rei>
Hi Cyril,
thanks for your time!
> I find this output to be a bit too verbose, frankly I do not remeber
> checking it content of the config.log ever.
It is verbose. The reason I added it is, that we can check that travis is doing what we
want (e.g. header / library is really installed / not installed).
I didn't realize, that include/config.h would be enough and it's much smaller.
But I suppose you don't want any output in case of successful configure run, do you?
> > + make $make_opts
> > + make $make_opts DESTDIR="$PREFIX" SKIP_IDCHECK=1 install
> ^
> Here you use spaces instead of tabs.
Thanks. Copy & paste issue.
> > +}
> > +
> > +build_in_tree()
> > +{
> > + echo "=== autotools ==="
> > + make autotools
> > +
> > + echo "=== configure ==="
> > + if ! ./configure $CONFIGURE_OPTS_IN_TREE $@; then
> > + echo "== ERROR: configure failed, config.log =="
> > + cat config.log
> > + exit 1
> > + fi
> > +
> > + echo "== config.log =="
> > + cat config.log
> Here as well.
> > +# vim: set ft=sh ts=4 sts=4 sw=4 noet:
> I prefer not to clobber source code with this kind of editor hints.
OK.
Kind regards,
Petr
next prev parent reply other threads:[~2017-12-04 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 12:25 [LTP] [RFC PATCH v3 0/5] Travis enhancements Petr Vorel
2017-12-04 12:25 ` [LTP] [RFC PATCH v3 1/5] travis: Add build script and use it in travis Petr Vorel
2017-12-04 17:15 ` Cyril Hrubis
2017-12-04 20:49 ` Petr Vorel [this message]
2017-12-06 10:20 ` Cyril Hrubis
2017-12-05 4:32 ` Li Wang
2017-12-04 12:25 ` [LTP] [RFC PATCH v3 2/5] travis: Drop old compilers, add new ones Petr Vorel
2017-12-04 12:25 ` [LTP] [RFC PATCH v3 3/5] travis: Add 32-bit cross-compile builds Petr Vorel
2017-12-04 12:25 ` [LTP] [RFC PATCH v3 4/5] travis: Add out-of-tree build Petr Vorel
2017-12-04 12:25 ` [LTP] [RFC PATCH v3 5/5] travis: Install all dependencies + add build with minimal dependencies Petr Vorel
2017-12-04 17:18 ` [LTP] [RFC PATCH v3 0/5] Travis enhancements Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204204949.GA7318@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.