From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/4] nvmet: Add feature close connection from target side
Date: Mon, 4 Dec 2017 23:40:57 +0100 [thread overview]
Message-ID: <20171204224057.GD19672@lst.de> (raw)
In-Reply-To: <ef34b468-8a34-1f6f-b782-2840f8318fcf@grimberg.me>
> The point is that ->delete_ctrl() is not designed to be safe for
> calling it multiple times (although it might be the case for rdma) and
> the code assumes that (which is wrong).
>
> You need to call it conditionally. See what is done in
> nvmet_ctrl_fatal_error()
Yes. In fact he should probably just call nvmet_ctrl_fatal_error.
next prev parent reply other threads:[~2017-12-04 22:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 12:29 [PATCH v2 0/4] Add controllers to nvmet configfs Israel Rukshin
2017-11-13 12:29 ` [PATCH 1/4] nvmet: Fix error flow in nvmet_alloc_ctrl() Israel Rukshin
2017-12-04 22:33 ` Christoph Hellwig
2017-11-13 12:29 ` [PATCH 2/4] nvmet: Rearrange nvmet_ctrl_free() Israel Rukshin
2017-12-04 22:33 ` Christoph Hellwig
2017-11-13 12:29 ` [PATCH 3/4] nvmet: Add controllers to configfs Israel Rukshin
2017-11-13 20:18 ` Sagi Grimberg
2017-11-14 10:04 ` Israel Rukshin
2017-12-04 22:39 ` Christoph Hellwig
2017-11-13 12:29 ` [PATCH 4/4] nvmet: Add feature close connection from target side Israel Rukshin
2017-11-13 20:21 ` Sagi Grimberg
2017-11-14 9:10 ` Israel Rukshin
2017-11-16 15:49 ` Sagi Grimberg
2017-12-04 22:40 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-10 11:40 [PATCH 0/4] Add controllers to nvmet configfs Israel Rukshin
2017-10-10 11:40 ` [PATCH 4/4] nvmet: Add feature close connection from target side Israel Rukshin
2017-10-11 11:20 ` Sagi Grimberg
2017-10-11 14:35 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204224057.GD19672@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.