All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Vikas Bansal <vikas.bansal@samsung.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"len.brown@intel.com" <len.brown@intel.com>,
	"pavel@ucw.cz" <pavel@ucw.cz>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: In kernel power management domain_pm created for async schedules
Date: Tue, 5 Dec 2017 14:27:00 +0100	[thread overview]
Message-ID: <20171205132700.GA13746@kroah.com> (raw)
In-Reply-To: <20171205092418epcms5p5c9404c09716e2efe84114cae3ce6b534@epcms5p5>

On Tue, Dec 05, 2017 at 09:24:18AM +0000, Vikas Bansal wrote:
> >From 8e948f8c697d661f38c2c3a85787e4c48b165adc Mon Sep 17 00:00:00 2001
> From: Vikas Bansal <vikas.bansal@samsung.com>
> Date: Tue, 5 Dec 2017 01:14:41 -0800

Why is all of this here in the patch itself?

> Subject: [PATCH] Put all the async schdules in PM core in domain with name
>  domain_pm. This avoids pm core to wait for async schedules
>  in system other than PM core.

Something went wrong with your commit, you have a very long subject and
no change log text :(

> Signed-off-by: Vikas Bansal <vikas.bansal@samsung.com>
> ---
>  drivers/base/power/main.c |   25 +++++++++++++------------
>  1 file changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index db2f044..2d19dfb 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -39,6 +39,7 @@
>  #include "power.h"
>  
>  typedef int (*pm_callback_t)(struct device *);
> +ASYNC_DOMAIN(domain_pm);

Why is this a global symbol?

I don't understand why this is needed, please explain the problem you
are having with the existing code.

thanks,

greg k-h

  reply	other threads:[~2017-12-05 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171205092418epcms5p5c9404c09716e2efe84114cae3ce6b534@epcms5p5>
2017-12-05  9:24 ` In kernel power management domain_pm created for async schedules Vikas Bansal
2017-12-05 13:27   ` gregkh [this message]
2017-12-05 15:28   ` Rafael J. Wysocki
     [not found] <CGME20171206053831epcms5p58903d153d261ffd797e43b6983cda1ce@epcms5p5>
2017-12-06  5:38 ` Vikas Bansal
2017-12-06  6:22   ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205132700.GA13746@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=vikas.bansal@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.