From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: yuan linyu <cugyly@163.com>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
Subject: Re: [PATCH v2 net-next] netlink: optimize err assignment
Date: Tue, 5 Dec 2017 15:03:10 -0800 [thread overview]
Message-ID: <20171205150310.41879699@xeon-e3> (raw)
In-Reply-To: <1512314409.19682.51.camel@gmail.com>
On Sun, 03 Dec 2017 07:20:09 -0800
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Sun, 2017-12-03 at 21:10 +0800, yuan linyu wrote:
> > From: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> >
> > Signed-off-by: yuan linyu <Linyu.Yuan@alcatel-sbell.com.cn>
> > ---
> > v2: fix kbuild test warning
> > ---
> > net/netlink/af_netlink.c | 52 ++++++++++++++++++++----------------
> > ------------
> > 1 file changed, 22 insertions(+), 30 deletions(-)
> >
>
> I see no reason why we should accept this code churn.
>
> This kind of change makes future fix backports harder.
>
I more worried about the possibility of latent bugs.
Humans aren't perfect at following all code paths
prev parent reply other threads:[~2017-12-05 23:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 13:10 [PATCH v2 net-next] netlink: optimize err assignment yuan linyu
2017-12-03 15:20 ` Eric Dumazet
2017-12-03 16:22 ` David Miller
2017-12-05 23:03 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205150310.41879699@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=cugyly@163.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.