From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMEmS-0002Ki-75 for qemu-devel@nongnu.org; Tue, 05 Dec 2017 10:05:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMEmM-00028b-G2 for qemu-devel@nongnu.org; Tue, 05 Dec 2017 10:05:08 -0500 Date: Tue, 5 Dec 2017 16:04:56 +0100 From: Cornelia Huck Message-ID: <20171205160456.6a2923e0.cohuck@redhat.com> In-Reply-To: <20171204140150.20483-6-david@redhat.com> References: <20171204140150.20483-1-david@redhat.com> <20171204140150.20483-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 for-2.12 5/9] s390x/tcg: Implement STORE CHANNEL PATH STATUS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Christian Borntraeger , Richard Henderson , Alexander Graf , Thomas Huth On Mon, 4 Dec 2017 15:01:46 +0100 David Hildenbrand wrote: > Just like KVM does, we should suppress this instruction: > When this instruction is not provided, it is > checked for privileged operation exception and the > instruction is suppressed by the machine > > Signed-off-by: David Hildenbrand > --- > target/s390x/insn-data.def | 1 + > target/s390x/translate.c | 7 +++++++ > 2 files changed, 8 insertions(+) Yes, given that we don't support real channel paths, we can't implement it in a useful way anyway.