From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v4 1/5] soc: qcom: Introduce QMI encoder/decoder Date: Tue, 5 Dec 2017 09:33:16 -0800 Message-ID: <20171205173316.GP28761@minitux> References: <20171130011644.9421-1-bjorn.andersson@linaro.org> <20171130011644.9421-2-bjorn.andersson@linaro.org> <6c6be375-6895-ecaf-9844-40774f6bdd5c@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pf0-f180.google.com ([209.85.192.180]:35661 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbdLERdX (ORCPT ); Tue, 5 Dec 2017 12:33:23 -0500 Received: by mail-pf0-f180.google.com with SMTP id j124so661379pfc.2 for ; Tue, 05 Dec 2017 09:33:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <6c6be375-6895-ecaf-9844-40774f6bdd5c@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Jitendra Sharma Cc: Andy Gross , Ohad Ben-Cohen , Arun Kumar Neelakantam , Chris Lew , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-remoteproc@vger.kernel.org On Fri 01 Dec 01:10 PST 2017, Jitendra Sharma wrote: > Hi Bjorn, > Hi Jitendra, > On 11/30/2017 6:46 AM, Bjorn Andersson wrote: > > +static int qmi_calc_min_msg_len(struct qmi_elem_info *ei_array, > > + int level) > > +{ > > + int min_msg_len = 0; > min_msg_len should be u32 as it would not be negative IMHO all these sizes should be size_t and there are a few places where we should add "const" specifier to pointers. But I refrained from "fixing" these up in an effort to keep things as close to the downstream implementation as possible. If Andy agrees I'm hoping that we can take this version and then follow up with a separate patch, making the review more explicit and make it easier to track down any potential regressions from such a change. Thank you for the review! Regards, Bjorn