From: Brandon Williams <bmwill@google.com>
To: Ben Boeckel <ben.boeckel@kitware.com>
Cc: git@vger.kernel.org, brad.king@kitware.com
Subject: Re: gitattributes not read for diff-tree anymore in 2.15?
Date: Tue, 5 Dec 2017 10:16:45 -0800 [thread overview]
Message-ID: <20171205181645.GA159917@google.com> (raw)
In-Reply-To: <20171205154244.GA16581@megas.kitware.com>
On 12/05, Ben Boeckel wrote:
> On Mon, Dec 04, 2017 at 15:03:55 -0800, Brandon Williams wrote:
> > Reading the attributes files should be done regardless if the gitmodules
> > file is read. The gitmodules file should only come into play if you are
> > dealing with submodules.
>
> Yeah, it doesn't seem to make sense why this commit breaks us, but there
> it is *shrug*.
While it doesn't make the most sense, I still wouldn't be surprised if I
missed something when writing that patch that inadvertently caused an
issue.
>
> > Do you mind providing a reproduction recipe with expected outcome vs
> > actual outcome and I can take a closer look.
>
> I'll work on one. It isn't as simple as I thought it was :) . The setup
> we do before running the checks is apparently involved as running it
> from the command line is not exhibiting the difference.
>
> --Ben
Perfect, thanks!
--
Brandon Williams
next prev parent reply other threads:[~2017-12-05 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 21:22 gitattributes not read for diff-tree anymore in 2.15? Ben Boeckel
2017-12-04 23:03 ` Brandon Williams
2017-12-05 15:42 ` Ben Boeckel
2017-12-05 18:16 ` Brandon Williams [this message]
2017-12-05 19:48 ` Ben Boeckel
2017-12-05 22:13 ` [PATCH] diff-tree: read the index so attribute checks work in bare repositories Brandon Williams
2017-12-05 22:29 ` Ben Boeckel
2017-12-05 22:31 ` Brandon Williams
2017-12-05 23:13 ` Junio C Hamano
2017-12-05 23:14 ` Stefan Beller
2017-12-06 21:47 ` Brandon Williams
2017-12-05 23:25 ` Eric Sunshine
2017-12-06 22:00 ` Brandon Williams
2017-12-06 22:07 ` Eric Sunshine
2017-12-06 22:02 ` [PATCH v2] " Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205181645.GA159917@google.com \
--to=bmwill@google.com \
--cc=ben.boeckel@kitware.com \
--cc=brad.king@kitware.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.