All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jim Mattson <jmattson@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: fix page leak in hardware_setup()
Date: Tue, 5 Dec 2017 22:37:58 +0100	[thread overview]
Message-ID: <20171205213757.GA17273@flask> (raw)
In-Reply-To: <20171201175756.16841-1-jmattson@google.com>

2017-12-01 09:57-0800, Jim Mattson:
> vmx_io_bitmap_b should not be allocated twice.
> 
> Fixes: 23611332938d ("KVM: VMX: refactor setup of global page-sized bitmaps")
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---

Applied, thanks.

>  arch/x86/kvm/vmx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 4704aaf6d19e..5fb5c4aff1cf 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6751,7 +6751,6 @@ static __init int hardware_setup(void)
>  			goto out;
>  	}
>  
> -	vmx_io_bitmap_b = (unsigned long *)__get_free_page(GFP_KERNEL);
>  	memset(vmx_vmread_bitmap, 0xff, PAGE_SIZE);
>  	memset(vmx_vmwrite_bitmap, 0xff, PAGE_SIZE);
>  
> -- 
> 2.15.0.531.g2ccb3012c9-goog
> 

  parent reply	other threads:[~2017-12-05 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 17:57 [PATCH] KVM: VMX: fix page leak in hardware_setup() Jim Mattson
2017-12-01 20:59 ` Krish Sadhukhan
2017-12-04  9:09 ` David Hildenbrand
2017-12-05 21:37 ` Radim Krčmář [this message]
2017-12-07  3:57 ` Quan Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205213757.GA17273@flask \
    --to=rkrcmar@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.