From: Andrew Lunn <andrew@lunn.ch>
To: Scott Branden <scott.branden@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Steve Lin <steven.lin1@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>,
netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command
Date: Tue, 5 Dec 2017 23:26:40 +0100 [thread overview]
Message-ID: <20171205222640.GA25752@lunn.ch> (raw)
In-Reply-To: <1512507203-17693-4-git-send-email-scott.branden@broadcom.com>
On Tue, Dec 05, 2017 at 12:53:23PM -0800, Scott Branden wrote:
> Add ETHTOOL_RESET support via --reset command.
>
> ie. ethtool --reset DEVNAME <flagname(s)>
>
> flagnames currently match the ETH_RESET_xxx names:
> mgmt,irq,dma,filter,offload,mac,phy,ram,dedicated,all
[Snip]
> +.B ethtool \-\-reset
> +.I devname
> +.BN flags
> +.RB [ mgmt ]
> +.RB [ irq ]
> +.RB [ dma ]
> +.RB [ filter ]
> +.RB [ offload ]
> +.RB [ mac ]
> +.RB [ phy ]
> +.RB [ ram ]
> +.RB [ ap ]
> +.RB [ dedicated ]
> +.RB [ all ]
Hi Scott
Just a nick pick. You don't list ap above, which is kind of why you
are doing this, if i remember correctly.
Andrew
next prev parent reply other threads:[~2017-12-05 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 20:53 [PATCH v2 0/3] ethtool: add ETHTOOL_RESET support via --reset command Scott Branden
2017-12-05 20:53 ` [PATCH v2 1/3] Revert "ethtool: Add DMA Coalescing support" Scott Branden
2017-12-05 20:53 ` [PATCH v2 2/3] ethtool-copy.h: sync with net-next Scott Branden
2017-12-05 20:53 ` [PATCH v2 3/3] ethtool: Add ETHTOOL_RESET support via --reset command Scott Branden
2017-12-05 21:30 ` Michal Kubecek
2017-12-05 22:06 ` Scott Branden
2017-12-05 22:29 ` Michal Kubecek
2017-12-06 0:45 ` Scott Branden
2017-12-05 22:26 ` Andrew Lunn [this message]
2017-12-05 22:31 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205222640.GA25752@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linville@tuxdriver.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
--cc=scott.branden@broadcom.com \
--cc=shemminger@vyatta.com \
--cc=steven.lin1@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.