From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [RFC][PATCHES] sock_alloc_file() cleanups and fixes Date: Tue, 5 Dec 2017 23:29:28 +0000 Message-ID: <20171205232928.GZ21978@ZenIV.linux.org.uk> References: <20171201002027.GI21978@ZenIV.linux.org.uk> <20171204.103524.186631681746357000.davem@davemloft.net> <20171204164100.GS21978@ZenIV.linux.org.uk> <20171205.144443.2120550314318217897.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:50530 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753011AbdLEX3b (ORCPT ); Tue, 5 Dec 2017 18:29:31 -0500 Content-Disposition: inline In-Reply-To: <20171205.144443.2120550314318217897.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Dec 05, 2017 at 02:44:43PM -0500, David Miller wrote: > From: Al Viro > Date: Mon, 4 Dec 2017 16:41:01 +0000 > > > On Mon, Dec 04, 2017 at 10:35:24AM -0500, David Miller wrote: > >> From: Al Viro > >> Date: Fri, 1 Dec 2017 00:20:27 +0000 > >> > >> > 1) massage sys_socketpair() (should be a pure cleanup) > >> > 2) fix and clean up kcm_clone() (-stable fodder) > >> > 3) switch sock_alloc_file() to new calling conventions. > >> > > >> > It got some local testing, but it certainly needs more review. > >> > Diffstat for the entire thing is > >> > >> Series looks great to me: > >> > >> Acked-by: David S. Miller > > > > How do you prefer it to be handled? KCM one should go into everything > > since 4.6 (with trivial modifications in 4.11 and 4.12 - both had > > massaged the place around the call of kcm_clone() a bit, but this fix > > overwrites the entire area and that can be dropped into earlier > > kernels without any problems). I've put that into vfs.git#net-fixes > > and have the other two in vfs.git#for-davem on top of that, with > > you merging the latter into net-next.git and the former - into net.git. > > Is that OK with you, or would you prefer some other way of handling > > that kind of stuff? > > Why don't you resubmit this to netdev as a non-RFC, I'll queue it up to > 'net' and -stable as well. Sent...