From: "Liu, Changcheng" <changcheng.liu@intel.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: neilb@suse.com, tglx@linutronix.de, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, kstewart@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/faddr2line: extend usage on generic arch
Date: Wed, 6 Dec 2017 09:35:47 +0800 [thread overview]
Message-ID: <20171206013547.GB83929@sofia> (raw)
In-Reply-To: <CAFLxGvzBan+1-3z2bPr34GrtodnJrG=P-BHHQHpAkurSDnGOoQ@mail.gmail.com>
On 22:30 Tue 05 Dec, Richard Weinberger wrote:
> On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng
> <changcheng.liu@intel.com> wrote:
> > fadd2line script should use the binary tool
> > used for the target system.
> >
> > Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>
> >
> > diff --git a/scripts/faddr2line b/scripts/faddr2line
> > index 1f5ce95..39e07d8 100755
> > --- a/scripts/faddr2line
> > +++ b/scripts/faddr2line
> > @@ -44,9 +44,16 @@
> > set -o errexit
> > set -o nounset
> >
> > +READELF="${CROSS_COMPILE}readelf"
> > +ADDR2LINE="${CROSS_COMPILE}addr2line"
> > +SIZE="${CROSS_COMPILE}size"
> > +NM="${CROSS_COMPILE}nm"
>
> How is this supposed to work when not cross compiling?
> When CROSS_COMPILE is not set this script will terminate because of
> the "set -o nounset" bash setting...
[Changcheng]:@Richard. Thx for your check. I've sent the fix patch to
resolve the unbound variable error.
>
> --
> Thanks,
> //richard
prev parent reply other threads:[~2017-12-06 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 9:29 [PATCH] scripts/faddr2line: extend usage on generic arch Liu, Changcheng
2017-12-05 21:30 ` Richard Weinberger
2017-12-06 1:35 ` Liu, Changcheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206013547.GB83929@sofia \
--to=changcheng.liu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.com \
--cc=richard.weinberger@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.