From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 0/2] netfilter: reduce size of hook entry points
Date: Wed, 6 Dec 2017 09:20:03 +0100 [thread overview]
Message-ID: <20171206082003.GB4076@salvia> (raw)
In-Reply-To: <20171202235848.22737-1-fw@strlen.de>
On Sun, Dec 03, 2017 at 12:58:46AM +0100, Florian Westphal wrote:
> struct net contains:
>
> struct nf_hook_entries __rcu *hooks[NFPROTO_NUMPROTO][NF_MAX_HOOKS];
>
> where NFPROTO_NUMPROTO = 13 and NF_MAX_HOOKS = 8.
>
> ... and that needs a *lot* more space than what we really need.
> We only need hooks for arp, bridge, ipv4, ipv6 and decnet.
>
> Arp only has 3 hook types, decnet has 7, all others have 5.
> So replace this with dedicated arrays of the correct size to save
> some space.
Also applied, thanks.
prev parent reply other threads:[~2017-12-06 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 23:58 [PATCH nf-next 0/2] netfilter: reduce size of hook entry points Florian Westphal
2017-12-02 23:58 ` [PATCH nf-next 1/2] netfilter: reduce size of hook entry point locations Florian Westphal
2017-12-02 23:58 ` [PATCH nf-next 2/2] netfilter: reduce hook array sizes to what is needed Florian Westphal
2017-12-06 18:14 ` Pablo Neira Ayuso
2017-12-06 8:20 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206082003.GB4076@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.