All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [RFC PATCH] target: detect read-only from underlying iblock device
Date: Wed, 06 Dec 2017 12:29:21 +0000	[thread overview]
Message-ID: <20171206132921.69f38c90@suse.de> (raw)
In-Reply-To: <20171205205442.25414-1-ddiss@suse.de>

On Wed, 6 Dec 2017 04:33:16 +0000, Bart Van Assche wrote:

> Although the patch itself looks fine to me: do we really need this kind of
> functionality in the kernel? Is it possible to implement the same functionality
> in user space?

Thanks for the feedback, Bart and Johannes. This functionality could
be handled in user-space, but having the error reported when the
backstore is enabled, rather than when the backstore->control node is
setup makes it less than intuitive for targetcli, etc.
Having targetcli call ioctl(BLKROGET) prior to issuing the
backstore->control I/O would probably be a cleaner user-space option.

Cheers, David

  parent reply	other threads:[~2017-12-06 12:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 20:54 [RFC PATCH] target: detect read-only from underlying iblock device David Disseldorp
2017-12-06  4:33 ` Bart Van Assche
2017-12-06  7:40 ` Johannes Thumshirn
2017-12-06 12:29 ` David Disseldorp [this message]
2017-12-07 14:47 ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206132921.69f38c90@suse.de \
    --to=ddiss@suse.de \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.