diff for duplicates of <20171206134702.GA12234@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 755e387..a034934 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -26,7 +26,7 @@ think it is warranted, thanks! > > > > See the log: > > > -> > > root at skl:/tmp# perf stat --per-thread -p 10322 -M CPI,IPC +> > > root@skl:/tmp# perf stat --per-thread -p 10322 -M CPI,IPC > > > ^C > > > Performance counter stats for process id '10322': > > > @@ -49,14 +49,14 @@ think it is warranted, thanks! > > > > > > > > I applied the diff but it's failed. > > > > -> > > > jinyao at skl:~/skl-ws/perf-dev/lck-4594/src$ patch -p1 < 1.pat +> > > > jinyao@skl:~/skl-ws/perf-dev/lck-4594/src$ patch -p1 < 1.pat > > > > patching file tools/perf/util/pmu.c > > > > patch: **** malformed patch at line 41: *head, struct perf_pmu *pmu) > > > > > > > > Could you send the patch as attachment to me in another mail thread? > > > > -> > > > to yao.jin at linux.intel.com -> > > > cc yao.jin at intel.com +> > > > to yao.jin@linux.intel.com +> > > > cc yao.jin@intel.com > > > > > > > > Thanks > > > > Jin Yao @@ -67,11 +67,11 @@ think it is warranted, thanks! > > > > > --- a/tools/perf/util/pmu.c > > > > > +++ b/tools/perf/util/pmu.c > > > > > @@ -538,6 +538,34 @@ static bool pmu_is_uncore(const char *name) -> > > > > ? } +> > > > > } > > > > > -> > > > > ? /* -> > > > > + *? PMU CORE devices have different name other than cpu in sysfs on some -> > > > > + *? platforms. looking for possible sysfs files to identify as core +> > > > > /* +> > > > > + * PMU CORE devices have different name other than cpu in sysfs on some +> > > > > + * platforms. looking for possible sysfs files to identify as core > > > > > device. > > > > > + */ > > > > > +static int is_pmu_core(const char *name) @@ -99,16 +99,16 @@ think it is warranted, thanks! > > > > > +} > > > > > + > > > > > +/* -> > > > > ?? * Return the CPU id as a raw string. -> > > > > ?? * -> > > > > ?? * Each architecture should provide a more precise id string that +> > > > > * Return the CPU id as a raw string. +> > > > > * +> > > > > * Each architecture should provide a more precise id string that > > > > > @@ -641,7 +669,7 @@ static void pmu_add_cpu_aliases(struct list_head > > > > > *head, struct perf_pmu *pmu) -> > > > > ?? break; -> > > > > ?? } +> > > > > break; +> > > > > } > > > > > > > > > > - if (pmu->is_uncore) { > > > > > + if (!is_pmu_core(name)) { -> > > > > ?? /* check for uncore devices */ -> > > > > ?? if (pe->pmu == NULL) -> > > > > ?? continue; +> > > > > /* check for uncore devices */ +> > > > > if (pe->pmu == NULL) +> > > > > continue; diff --git a/a/content_digest b/N1/content_digest index 5da215b..b33caf2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,10 +6,27 @@ "ref\01f79aa3c-a061-7c55-5d3e-f13638be01ad@linux.intel.com\0" "ref\020171205184242.GA19952@kernel.org\0" "ref\071db0255-af9b-968a-7baa-238d7146f069@linux.intel.com\0" - "From\0acme@kernel.org (Arnaldo Carvalho de Melo)\0" - "Subject\0[PATCH v9 3/5] perf utils: use pmu->is_uncore to detect PMU UNCORE devices\0" + "From\0Arnaldo Carvalho de Melo <acme@kernel.org>\0" + "Subject\0Re: [PATCH v9 3/5] perf utils: use pmu->is_uncore to detect PMU UNCORE devices\0" "Date\0Wed, 6 Dec 2017 10:47:02 -0300\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Jin" + " Yao <yao.jin@linux.intel.com>\0" + "Cc\0Ganapatrao Kulkarni <gklkml16@gmail.com>" + Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com> + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + Will Deacon <Will.Deacon@arm.com> + catalin.marinas@arm.com + mark.rutland@arm.com + Alexander Shishkin <alexander.shishkin@linux.intel.com> + Peter Zijlstra <peterz@infradead.org> + Ingo Molnar <mingo@redhat.com> + jnair@caviumnetworks.com + Zhangshaokun <zhangshaokun@hisilicon.com> + Jonathan.Cameron@huawei.com + Robert Richter <Robert.Richter@cavium.com> + Jin + " Yao <yao.jin@intel.com>\0" "\00:1\0" "b\0" "Em Wed, Dec 06, 2017 at 08:30:37AM +0800, Jin, Yao escreveu:\n" @@ -40,7 +57,7 @@ "> \n" "> > > See the log:\n" "> > > \n" - "> > > root at skl:/tmp# perf stat --per-thread -p 10322 -M CPI,IPC\n" + "> > > root@skl:/tmp# perf stat --per-thread -p 10322 -M CPI,IPC\n" "> > > ^C\n" "> > > Performance counter stats for process id '10322':\n" "> > > \n" @@ -63,14 +80,14 @@ "> > > > \n" "> > > > I applied the diff but it's failed.\n" "> > > > \n" - "> > > > jinyao at skl:~/skl-ws/perf-dev/lck-4594/src$ patch -p1 < 1.pat\n" + "> > > > jinyao@skl:~/skl-ws/perf-dev/lck-4594/src$ patch -p1 < 1.pat\n" "> > > > patching file tools/perf/util/pmu.c\n" "> > > > patch: **** malformed patch at line 41: *head, struct perf_pmu *pmu)\n" "> > > > \n" "> > > > Could you send the patch as attachment to me in another mail thread?\n" "> > > > \n" - "> > > > to yao.jin at linux.intel.com\n" - "> > > > cc yao.jin at intel.com\n" + "> > > > to yao.jin@linux.intel.com\n" + "> > > > cc yao.jin@intel.com\n" "> > > > \n" "> > > > Thanks\n" "> > > > Jin Yao\n" @@ -81,11 +98,11 @@ "> > > > > --- a/tools/perf/util/pmu.c\n" "> > > > > +++ b/tools/perf/util/pmu.c\n" "> > > > > @@ -538,6 +538,34 @@ static bool pmu_is_uncore(const char *name)\n" - "> > > > > ? }\n" + "> > > > > \302\240 }\n" "> > > > > \n" - "> > > > > ? /*\n" - "> > > > > + *? PMU CORE devices have different name other than cpu in sysfs on some\n" - "> > > > > + *? platforms. looking for possible sysfs files to identify as core\n" + "> > > > > \302\240 /*\n" + "> > > > > + *\302\240 PMU CORE devices have different name other than cpu in sysfs on some\n" + "> > > > > + *\302\240 platforms. looking for possible sysfs files to identify as core\n" "> > > > > device.\n" "> > > > > + */\n" "> > > > > +static int is_pmu_core(const char *name)\n" @@ -113,18 +130,18 @@ "> > > > > +}\n" "> > > > > +\n" "> > > > > +/*\n" - "> > > > > ?? * Return the CPU id as a raw string.\n" - "> > > > > ?? *\n" - "> > > > > ?? * Each architecture should provide a more precise id string that\n" + "> > > > > \302\240\302\240 * Return the CPU id as a raw string.\n" + "> > > > > \302\240\302\240 *\n" + "> > > > > \302\240\302\240 * Each architecture should provide a more precise id string that\n" "> > > > > @@ -641,7 +669,7 @@ static void pmu_add_cpu_aliases(struct list_head\n" "> > > > > *head, struct perf_pmu *pmu)\n" - "> > > > > ?? break;\n" - "> > > > > ?? }\n" + "> > > > > \302\240\302\240 break;\n" + "> > > > > \302\240\302\240 }\n" "> > > > > \n" "> > > > > - if (pmu->is_uncore) {\n" "> > > > > + if (!is_pmu_core(name)) {\n" - "> > > > > ?? /* check for uncore devices */\n" - "> > > > > ?? if (pe->pmu == NULL)\n" - > > > > > ?? continue; + "> > > > > \302\240\302\240 /* check for uncore devices */\n" + "> > > > > \302\240\302\240 if (pe->pmu == NULL)\n" + "> > > > > \302\240\302\240 continue;" -996d36b9c2703c5a837a59360c54afa65b211a6a6b18c22e4b800937a3e2bdae +1fcf78920a44e9270d0b868358f298385508a3203b4f8daa82def6476b787c38
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.