From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbdLFPBU (ORCPT ); Wed, 6 Dec 2017 10:01:20 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46298 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbdLFPBR (ORCPT ); Wed, 6 Dec 2017 10:01:17 -0500 Date: Wed, 6 Dec 2017 16:01:23 +0100 From: Greg KH To: Tomas Marek Cc: devel@driverdev.osuosl.org, joe@perches.com, linux-kernel@vger.kernel.org, dan.carpenter@oracle.com Subject: Re: [PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c Message-ID: <20171206150123.GA9143@kroah.com> References: <1512420010-20240-1-git-send-email-marek_tomas@centrum.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512420010-20240-1-git-send-email-marek_tomas@centrum.cz> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2017 at 09:40:10PM +0100, Tomas Marek wrote: > This patch fix several brace on next line, braces not necessary, space > around =/<, and space before/after open/close parenthesis coding style > errors find by checkpatch in pi433_if.c. > > In addition, the interrupt routine DIO0_irq_handler logic is updated: > - use 'switch' statement instead of 'if/else if' combination for the > sake of readability, and > - use dev_dbg_ratelimited instead of dev_dbg to avoid message flooding. When you have to add "in addition" to a changelog comment, that's a huge flag that the patch needs to be broken up into a patch series. Please do that here, only doing one "logical" thing at a time. As it is, it's hard to review this way. thanks, greg k-h