From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752325AbdLFPS5 (ORCPT ); Wed, 6 Dec 2017 10:18:57 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49928 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdLFPS5 (ORCPT ); Wed, 6 Dec 2017 10:18:57 -0500 Date: Wed, 6 Dec 2017 16:19:03 +0100 From: Greg Kroah-Hartman To: Nguyen Phan Quang Minh Cc: Dan Carpenter , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro Message-ID: <20171206151903.GA11701@kroah.com> References: <20171130214014.GA4405@minhnpqrs-antergos> <20171203000949.GA19959@minhnpqrs-antergos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171203000949.GA19959@minhnpqrs-antergos> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote: > The macro calls its argument -a function- twice, makes the calling > function return prematurely -skipping resource cleanup code- and hurts > understandability. > > Signed-off-by: Nguyen Phan Quang Minh > --- > Base on Dan's feedback, I checked and the macro return indeed skips over > some cleanup code, hence remove it. > The code is not pretty, any hints on how to do it better is greatly > appreciated. Please redo this based on Dan's comments. thanks, greg k-h