All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Klauer <Andreas.Klauer@metamorpher.de>
To: Phil Turmel <philip@turmel.org>
Cc: Jeremy Graham <jeremy@doghouse.agency>, linux-raid@vger.kernel.org
Subject: Re: mdadm stuck at 0% reshape after grow
Date: Wed, 6 Dec 2017 17:03:46 +0100	[thread overview]
Message-ID: <20171206160346.GA5806@metamorpher.de> (raw)
In-Reply-To: <61c9e4bd-1605-5b17-80ce-c738b80b7058@turmel.org>

On Wed, Dec 06, 2017 at 09:15:21AM -0500, Phil Turmel wrote:
> The problem with this is that the sectors currently marked don't have
> appropriate data.

It might have the correct data. Depends what exactly happened.
If it happened years ago and you never noticed until reshape, 
chances are it won't matter one way or another.

Of course, it doesn't hurt to take additional steps, if you have 
backups to compare with or some other way to check file integrity. 

> > If you have a filesystem with bad blocks management on top of it, 
> > check that too and clear it if necessary.
> 
> MD's BBL system doesn't coordinate with the filesystem on top, so this
> is meaningless.

MD with duped BBLs does return read errors, so it's a possibility.
 
> The BBL in MD is woefully incomplete and should *never* be used.

There's ups and downs to everything. Relocations would be awful too. 
Harms performance and makes recovery all but impossible. So many people 
on this list with lost metadata, figuring out RAID layout and drive 
oder is hard, but figuring out random relocations is impossible.

The BBL could be improved a lot if it prevented BBLs to be identical 
across drives, and gave bad blocks a second chance. Once the cable 
problem is solved, MD should help you turning those bad blocks back 
into good ones.

And if your drive actually has real bad blocks, the only correct course 
of action is to replace it entirely. The problem with BBL right now is 
that even if you replace all drives, the BBL stays. Once it's duplicated 
you are stuck with it forever until you forcibly remove it.

Regards
Andreas Klauer

  reply	other threads:[~2017-12-06 16:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  9:41 mdadm stuck at 0% reshape after grow Jeremy Graham
2017-12-05 10:56 ` Wols Lists
2017-12-05 15:49   ` Nix
2017-12-05 15:55 ` 002
2017-12-06  2:51   ` Phil Turmel
2017-12-06  4:33     ` Jeremy Graham
2017-12-06  7:36       ` Jeremy Graham
2017-12-06 13:34         ` Wols Lists
2017-12-06 14:02         ` 002
2017-12-06 10:49       ` Andreas Klauer
2017-12-06 14:15         ` Phil Turmel
2017-12-06 16:03           ` Andreas Klauer [this message]
2017-12-06 16:21             ` Phil Turmel
2017-12-06 18:24               ` 002
2017-12-07  8:40                 ` Jeremy Graham
2017-12-06 20:19               ` Edward Kuns
2017-12-07 10:26                 ` Wols Lists
2017-12-07 13:58                 ` Andreas Klauer
2017-12-07 17:06                   ` Wols Lists
2017-12-07 17:40                   ` Andreas Klauer
2017-12-07 20:31                     ` Wols Lists
2017-12-07 23:40                     ` Wols Lists
2017-12-08  1:25                       ` 002
2017-12-09  0:20                       ` Edward Kuns
2017-12-14 12:43                         ` Brad Campbell
2017-12-14 17:32                           ` Edward Kuns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206160346.GA5806@metamorpher.de \
    --to=andreas.klauer@metamorpher.de \
    --cc=jeremy@doghouse.agency \
    --cc=linux-raid@vger.kernel.org \
    --cc=philip@turmel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.