From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v2 8/8] net/mlx4: remove Tx completion elements counter Date: Wed, 6 Dec 2017 17:22:55 +0100 Message-ID: <20171206162255.GJ4062@6wind.com> References: <1511871570-16826-1-git-send-email-matan@mellanox.com> <1512571693-15338-1-git-send-email-matan@mellanox.com> <1512571693-15338-9-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Matan Azrad Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 35B987CFC for ; Wed, 6 Dec 2017 17:23:07 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id g130so23836003wme.0 for ; Wed, 06 Dec 2017 08:23:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <1512571693-15338-9-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 06, 2017 at 02:48:13PM +0000, Matan Azrad wrote: > This counter saved the descriptor elements which are waiting to be > completted and was used to know if completion function should be Looks like you forgot one minor change before adding my ack: completted => completed > called. > > This completion check can be done by other elements management > variables and we can prevent this counter management. > > Remove this counter and replace the completion check easily by other > elements management variables. > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND