From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]:26055 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdLFUKQ (ORCPT ); Wed, 6 Dec 2017 15:10:16 -0500 Date: Wed, 6 Dec 2017 13:10:14 -0700 From: Ross Zwisler Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206201014.GA27401@linux.intel.com> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171206002743.GC5858@dastard> Sender: fstests-owner@vger.kernel.org Content-Transfer-Encoding: quoted-printable To: Dave Chinner Cc: Ross Zwisler , linux-xfs , linux-nvdimm , fstests , Jan Kara , Dan Williams , "Darrick J . Wong" List-ID: On Wed, Dec 06, 2017 at 11:27:43AM +1100, Dave Chinner wrote: > On Tue, Dec 05, 2017 at 04:56:49PM -0700, Ross Zwisler wrote: > > I recently upgraded my compiler from > > gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) > > to > > gcc (GCC) 7.2.1 20170915 (Red Hat 7.2.1-2) > > and started getting a bunch of compiler warnings in io/fsmap.c: > >=20 > > fsmap.c: In function =E2=80=98fsmap_f=E2=80=99: > > fsmap.c:228:40: warning: =E2=80=98%lld=E2=80=99 directive output ma= y be truncated writing > > between 1 and 17 bytes into a region of size between 12 and 28 > > [-Wformat-truncation=3D] > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > ^~~~ > > fsmap.c:228:32: note: directive argument in the range [0, 360287970= 18963967] > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > ^~~~~~~~~~~~~~~ > > fsmap.c:228:3: note: =E2=80=98snprintf=E2=80=99 output between 8 an= d 40 bytes into a > > destination of size 32 > > snprintf(bbuf, sizeof(bbuf), "[%lld..%lld]:", > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > (long long)BTOBBT(p->fmr_physical), > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > (long long)BTOBBT(p->fmr_physical + p->fmr_length - 1)); > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >=20 > > The issue is that 'bbuf' is only defined to be 32 characters wide, bu= t each > > signed long long can potentially print as many as 19 characters > > (9223372036854775807 is the max value). The format we're using for b= buf is > > "[%lld..%lld]:" which has 2 signed long longs plus 6 other characters > > "[..]:\0", which means it's possible we'll print up to 44 characters, > > overflowing our 32 char buffer. > >=20 > > Fix this by bumping all the buffer sizes in dump_map_verbose() to 64 > > characters. > >=20 > > Signed-off-by: Ross Zwisler > > Cc: Darrick J. Wong > > Fixes: 3fcab549a234 ("xfs_io: support the new getfsmap ioctl") >=20 > FYI, I posted a fix for this weeks ago. I think Eric has already > picked it up, but it hasn't been pushed out into the for-next branch > yet. I'm seeing similar new compiler warnings when compiling xfstests: write_log.c: In function =E2=80=98wlog_open=E2=80=99: write_log.c:124:37: warning: =E2=80=98%s=E2=80=99 directive writing up to= 1023 bytes into a region of size 224 [-Wformat-overflow=3D] "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", ^~ write_log.c:124:4: note: directive argument in the range [1089, 2047] "Could not open write_log - open(%s, %#o, %#o) failed: %s\n", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ etc. I don't see any patches posted that fix these, as of yet. As far as you = know, am I correct in thinking that these still need to be fixed? - Ross From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 718A82217CE42 for ; Wed, 6 Dec 2017 12:05:43 -0800 (PST) Date: Wed, 6 Dec 2017 13:10:14 -0700 From: Ross Zwisler Subject: Re: [xfsprogs PATCH v2 1/3] xfs_io: fix compiler warnings in getfsmap code Message-ID: <20171206201014.GA27401@linux.intel.com> References: <20171205235651.17102-1-ross.zwisler@linux.intel.com> <20171205235651.17102-2-ross.zwisler@linux.intel.com> <20171206002743.GC5858@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171206002743.GC5858@dastard> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Chinner Cc: Jan Kara , linux-nvdimm , "Darrick J . Wong" , fstests , linux-xfs List-ID: T24gV2VkLCBEZWMgMDYsIDIwMTcgYXQgMTE6Mjc6NDNBTSArMTEwMCwgRGF2ZSBDaGlubmVyIHdy b3RlOgo+IE9uIFR1ZSwgRGVjIDA1LCAyMDE3IGF0IDA0OjU2OjQ5UE0gLTA3MDAsIFJvc3MgWndp c2xlciB3cm90ZToKPiA+IEkgcmVjZW50bHkgdXBncmFkZWQgbXkgY29tcGlsZXIgZnJvbQo+ID4g CWdjYyAoR0NDKSA2LjQuMSAyMDE3MDcyNyAoUmVkIEhhdCA2LjQuMS0xKQo+ID4gdG8KPiA+IAln Y2MgKEdDQykgNy4yLjEgMjAxNzA5MTUgKFJlZCBIYXQgNy4yLjEtMikKPiA+IGFuZCBzdGFydGVk IGdldHRpbmcgYSBidW5jaCBvZiBjb21waWxlciB3YXJuaW5ncyBpbiBpby9mc21hcC5jOgo+ID4g Cj4gPiAgIGZzbWFwLmM6IEluIGZ1bmN0aW9uIOKAmGZzbWFwX2bigJk6Cj4gPiAgIGZzbWFwLmM6 MjI4OjQwOiB3YXJuaW5nOiDigJglbGxk4oCZIGRpcmVjdGl2ZSBvdXRwdXQgbWF5IGJlIHRydW5j YXRlZCB3cml0aW5nCj4gPiAgIGJldHdlZW4gMSBhbmQgMTcgYnl0ZXMgaW50byBhIHJlZ2lvbiBv ZiBzaXplIGJldHdlZW4gMTIgYW5kIDI4Cj4gPiAgIFstV2Zvcm1hdC10cnVuY2F0aW9uPV0KPiA+ ICAgICAgc25wcmludGYoYmJ1Ziwgc2l6ZW9mKGJidWYpLCAiWyVsbGQuLiVsbGRdOiIsCj4gPiAg IF5+fn4KPiA+ICAgZnNtYXAuYzoyMjg6MzI6IG5vdGU6IGRpcmVjdGl2ZSBhcmd1bWVudCBpbiB0 aGUgcmFuZ2UgWzAsIDM2MDI4Nzk3MDE4OTYzOTY3XQo+ID4gICAgICBzbnByaW50ZihiYnVmLCBz aXplb2YoYmJ1ZiksICJbJWxsZC4uJWxsZF06IiwKPiA+ICAgXn5+fn5+fn5+fn5+fn5+Cj4gPiAg IGZzbWFwLmM6MjI4OjM6IG5vdGU6IOKAmHNucHJpbnRm4oCZIG91dHB1dCBiZXR3ZWVuIDggYW5k IDQwIGJ5dGVzIGludG8gYQo+ID4gICBkZXN0aW5hdGlvbiBvZiBzaXplIDMyCj4gPiAgICAgIHNu cHJpbnRmKGJidWYsIHNpemVvZihiYnVmKSwgIlslbGxkLi4lbGxkXToiLAo+ID4gICAgICBefn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiA+ICAgKGxvbmcgbG9u ZylCVE9CQlQocC0+Zm1yX3BoeXNpY2FsKSwKPiA+ICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fgo+ID4gICAobG9uZyBsb25nKUJUT0JCVChwLT5mbXJfcGh5c2ljYWwgKyBwLT5m bXJfbGVuZ3RoIC0gMSkpOwo+ID4gICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn4KPiA+IAo+ID4gVGhlIGlzc3VlIGlzIHRoYXQgJ2JidWYnIGlz IG9ubHkgZGVmaW5lZCB0byBiZSAzMiBjaGFyYWN0ZXJzIHdpZGUsIGJ1dCBlYWNoCj4gPiBzaWdu ZWQgbG9uZyBsb25nIGNhbiBwb3RlbnRpYWxseSBwcmludCBhcyBtYW55IGFzIDE5IGNoYXJhY3Rl cnMKPiA+ICg5MjIzMzcyMDM2ODU0Nzc1ODA3IGlzIHRoZSBtYXggdmFsdWUpLiAgVGhlIGZvcm1h dCB3ZSdyZSB1c2luZyBmb3IgYmJ1ZiBpcwo+ID4gIlslbGxkLi4lbGxkXToiIHdoaWNoIGhhcyAy IHNpZ25lZCBsb25nIGxvbmdzIHBsdXMgNiBvdGhlciBjaGFyYWN0ZXJzCj4gPiAiWy4uXTpcMCIs IHdoaWNoIG1lYW5zIGl0J3MgcG9zc2libGUgd2UnbGwgcHJpbnQgdXAgdG8gNDQgY2hhcmFjdGVy cywKPiA+IG92ZXJmbG93aW5nIG91ciAzMiBjaGFyIGJ1ZmZlci4KPiA+IAo+ID4gRml4IHRoaXMg YnkgYnVtcGluZyBhbGwgdGhlIGJ1ZmZlciBzaXplcyBpbiBkdW1wX21hcF92ZXJib3NlKCkgdG8g NjQKPiA+IGNoYXJhY3RlcnMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFJvc3MgWndpc2xlciA8 cm9zcy56d2lzbGVyQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBEYXJyaWNrIEouIFdvbmcgPGRh cnJpY2sud29uZ0BvcmFjbGUuY29tPgo+ID4gRml4ZXM6IDNmY2FiNTQ5YTIzNCAoInhmc19pbzog c3VwcG9ydCB0aGUgbmV3IGdldGZzbWFwIGlvY3RsIikKPiAKPiBGWUksIEkgcG9zdGVkIGEgZml4 IGZvciB0aGlzIHdlZWtzIGFnby4gSSB0aGluayBFcmljIGhhcyBhbHJlYWR5Cj4gcGlja2VkIGl0 IHVwLCBidXQgaXQgaGFzbid0IGJlZW4gcHVzaGVkIG91dCBpbnRvIHRoZSBmb3ItbmV4dCBicmFu Y2gKPiB5ZXQuCgpJJ20gc2VlaW5nIHNpbWlsYXIgbmV3IGNvbXBpbGVyIHdhcm5pbmdzIHdoZW4g Y29tcGlsaW5nIHhmc3Rlc3RzOgoKd3JpdGVfbG9nLmM6IEluIGZ1bmN0aW9uIOKAmHdsb2dfb3Bl buKAmToKd3JpdGVfbG9nLmM6MTI0OjM3OiB3YXJuaW5nOiDigJglc+KAmSBkaXJlY3RpdmUgd3Jp dGluZyB1cCB0byAxMDIzIGJ5dGVzIGludG8gYSByZWdpb24gb2Ygc2l6ZSAyMjQgWy1XZm9ybWF0 LW92ZXJmbG93PV0KICAgICJDb3VsZCBub3Qgb3BlbiB3cml0ZV9sb2cgLSBvcGVuKCVzLCAlI28s ICUjbykgZmFpbGVkOiAgJXNcbiIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBefgp3cml0ZV9sb2cuYzoxMjQ6NDogbm90ZTogZGlyZWN0aXZlIGFyZ3VtZW50IGluIHRoZSBy YW5nZSBbMTA4OSwgMjA0N10KICAgICJDb3VsZCBub3Qgb3BlbiB3cml0ZV9sb2cgLSBvcGVuKCVz LCAlI28sICUjbykgZmFpbGVkOiAgJXNcbiIsCiAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CgpldGMuCgpJIGRvbid0IHNlZSBh bnkgcGF0Y2hlcyBwb3N0ZWQgdGhhdCBmaXggdGhlc2UsIGFzIG9mIHlldC4gIEFzIGZhciBhcyB5 b3Uga25vdywKYW0gSSBjb3JyZWN0IGluIHRoaW5raW5nIHRoYXQgdGhlc2Ugc3RpbGwgbmVlZCB0 byBiZSBmaXhlZD8KCi0gUm9zcwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4w MS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K