From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Date: Wed, 6 Dec 2017 13:39:00 -0800 Message-ID: <20171206213858.GA14257@google.com> References: <1512551301-12946-1-git-send-email-nickey.yang@rock-chips.com> <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nickey Yang Cc: mark.rutland@arm.com, airlied@linux.ie, hoegsberg@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, philippe.cornu@st.com, yannick.fertre@st.com, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, laurent.pinchart@ideasonboard.com, zyw@rock-chips.com, xbl@rock-chips.com, mka@chromium.org, hl@rock-chips.com List-Id: linux-rockchip.vger.kernel.org T24gV2VkLCBEZWMgMDYsIDIwMTcgYXQgMDU6MDg6MTlQTSArMDgwMCwgTmlja2V5IFlhbmcgd3Jv dGU6Cj4gRnJvbTogQnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJvbWl1bS5vcmc+Cj4gCj4g QnJpZGdlIGRyaXZlcnMvaGVscGVycyBzaG91bGRuJ3QgYmUgY2xvYmJlcmluZyB0aGUgZHJ2ZGF0 YSwgc2luY2UgYQo+IHBhcmVudCBkcml2ZXIgbWlnaHQgbmVlZCB0byBvd24gdGhpcy4gSW5zdGVh ZCwgbGV0J3MgcmV0dXJuIG91cgo+ICdkd19taXBpX2RzaScgb2JqZWN0IGFuZCBoYXZlIGNhbGxl cnMgcGFzcyB0aGF0IGJhY2sgdG8gdXMgZm9yIHJlbW92YWwuCj4gCj4gU2lnbmVkLW9mZi1ieTog QnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJvbWl1bS5vcmc+Cj4gU2lnbmVkLW9mZi1ieTog Tmlja2V5IFlhbmcgPG5pY2tleS55YW5nQHJvY2stY2hpcHMuY29tPgo+IExpbms6aHR0cHM6Ly9w YXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA3ODQ5My8KPiAKPiAtLS0KPiBDaGFuZ2VzCj4g Cj4gdjQ6Cj4gLSBBZGQgRnJvbSB0YWcsdXBkYXRlIHN1YmplY3QgbGluZQo+IC0ga2VlcCBwYXRj aCAiZHJtL3N0bTogZHNpOiBBZGp1c3QgZHdfbWlwaV9kc2lfcHJvYmUgYW5kIHJlbW92ZSIKPiAg IGluIHRoaXMgcGllY2UgdG9nZXRoZXIuCj4gCj4gdjU6Cj4gLSByZW1vdmUgUmV2aWV3ICYgQWNr IHRhZwo+IC0gZml4IHJlbW92ZSgpIGRpcmVjdGx5IHJlZmVyZW5jaW5nIHRoZSBzdGF0aWMKPiAg IGR3X21pcGlfZHNpX3N0bV9wbGF0X2RhdGEgc3RydWN0LgoKWW91J3ZlIGdvdHRlbiB0aGlzIGJh Y2sgaW50byBiYXNpY2FsbHkgdGhlIHNoYXBlIEkgc2VudCB2MSBpbiwgc28gSQpndWVzcyB0aGlz IGRlc2VydmVzIGFuOgoKQWNrZWQtYnk6IEJyaWFuIE5vcnJpcyA8YnJpYW5ub3JyaXNAY2hyb21p dW0ub3JnPgoKOikKCk9ubHkgbmV0IGNoYW5nZXM6IHlvdSByZW5hbWVkIHRoZSAnZHNpJyBmaWVs ZCB0byAnZG1kJyAoRHdjIE1pcGkKRGV2aWNlPyksIGFuZCBteSAncmV0dXJuIDAnIGNoYW5nZWQg YmFjayB0byB0aGUgb3JpZ2luYWwgJ3JldHVybiByZXQnIGF0CnRoZSBlbmQgb2YgcHJvYmUoKS4g RG9lc24ndCBtYWtlIGFueSBmdW5jdGlvbmFsIGRpZmZlcmVuY2UsIHNvIGZpbmUgd2l0aAptZS4K CklmIGV2ZXJ5Ym9keSdzIGp1c3QgYXMgaGFwcHkgd2l0aCB0aGlzIGFzIHdpdGggdGhlIGZpcnN0 CnZlcnNpb24uLi5zaG91bGQgaXQganVzdCBiZSBhcHBsaWVkIG5vdywgcmVnYXJkbGVzcyBvZiB0 aGUgc3RhdHVzIG9mIHRoZQpuZXh0IDIgcGF0Y2hlcz8gQ291bGQgaGVscCByZWR1Y2UgdGhlIGRp c2N1c3Npb24gKGFuZCBjb25mdXNpb24pCnN1cmZhY2UuCgpSZWdhcmRzLApCcmlhbgoKPiAgZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jIHwgMzYgKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9zdG0vZHdfbWlwaV9kc2ktc3Rt LmMgICAgICAgICB8IDEwICsrKysrLS0tCj4gIGluY2x1ZGUvZHJtL2JyaWRnZS9kd19taXBpX2Rz aS5oICAgICAgICAgICAgICB8IDE3ICsrKysrKysrLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAz MCBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKLi4uCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752587AbdLFVjI (ORCPT ); Wed, 6 Dec 2017 16:39:08 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36561 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751610AbdLFVjD (ORCPT ); Wed, 6 Dec 2017 16:39:03 -0500 X-Google-Smtp-Source: AGs4zMYpZbPIB/HHWsrePywfnj6l41sBEdadsx/0HYlceTdyGEbyvUfYNM5ciQ56nUKA3Drc+kqk+Q== Date: Wed, 6 Dec 2017 13:39:00 -0800 From: Brian Norris To: Nickey Yang Cc: robh+dt@kernel.org, heiko@sntech.de, mark.rutland@arm.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, laurent.pinchart@ideasonboard.com, seanpaul@chromium.org, mka@chromium.org, hoegsberg@gmail.com, architt@codeaurora.org, philippe.cornu@st.com, yannick.fertre@st.com, hl@rock-chips.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v6 1/3] drm/bridge/synopsys: dsi: stop clobbering drvdata Message-ID: <20171206213858.GA14257@google.com> References: <1512551301-12946-1-git-send-email-nickey.yang@rock-chips.com> <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512551301-12946-2-git-send-email-nickey.yang@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 05:08:19PM +0800, Nickey Yang wrote: > From: Brian Norris > > Bridge drivers/helpers shouldn't be clobbering the drvdata, since a > parent driver might need to own this. Instead, let's return our > 'dw_mipi_dsi' object and have callers pass that back to us for removal. > > Signed-off-by: Brian Norris > Signed-off-by: Nickey Yang > Link:https://patchwork.kernel.org/patch/10078493/ > > --- > Changes > > v4: > - Add From tag,update subject line > - keep patch "drm/stm: dsi: Adjust dw_mipi_dsi_probe and remove" > in this piece together. > > v5: > - remove Review & Ack tag > - fix remove() directly referencing the static > dw_mipi_dsi_stm_plat_data struct. You've gotten this back into basically the shape I sent v1 in, so I guess this deserves an: Acked-by: Brian Norris :) Only net changes: you renamed the 'dsi' field to 'dmd' (Dwc Mipi Device?), and my 'return 0' changed back to the original 'return ret' at the end of probe(). Doesn't make any functional difference, so fine with me. If everybody's just as happy with this as with the first version...should it just be applied now, regardless of the status of the next 2 patches? Could help reduce the discussion (and confusion) surface. Regards, Brian > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 36 ++++++++++----------------- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 10 +++++--- > include/drm/bridge/dw_mipi_dsi.h | 17 ++++++++----- > 3 files changed, 30 insertions(+), 33 deletions(-) ...