From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: "Tobin C. Harding" <me@tobin.cc>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] checkpatch: add check for tag Co-Developed-by
Date: Thu, 7 Dec 2017 07:55:54 +0100 [thread overview]
Message-ID: <20171207065554.GA19722@kroah.com> (raw)
In-Reply-To: <1512628466.960.30.camel@perches.com>
On Wed, Dec 06, 2017 at 10:34:26PM -0800, Joe Perches wrote:
> On Thu, 2017-12-07 at 11:59 +1100, Tobin C. Harding wrote:
> > Recently signature tag Co-Developed-by was added to the
> > kernel (Documentation/process/5.Posting.rst). checkpatch.pl doesn't know
> > about it yet. All prior tags used all lowercase characters except for first
> > character. Checks for this format had to be re-worked to allow for the
> > new tag.
> >
> > Add checkpatch checks for Co-Developed-by tag.
> []
> > +++ b/scripts/checkpatch.pl
> > @@ -468,6 +468,7 @@ our $signature_tags = qr{(?xi:
> > Reviewed-by:|
> > Reported-by:|
> > Suggested-by:|
> > + Co-Developed-by:|
>
> I think the extra hyphenate form is poor at best.
> Codeveloped-by: should be the only form.
That's not what Documentation/process/5.Posting.rst says, sorry.
So Tobin's patch is correct.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-07 6:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 0:59 [PATCH] checkpatch: add check for tag Co-Developed-by Tobin C. Harding
2017-12-07 6:34 ` Joe Perches
2017-12-07 6:55 ` Greg Kroah-Hartman [this message]
2017-12-07 6:59 ` Joe Perches
2017-12-07 6:56 ` Greg Kroah-Hartman
2017-12-07 16:26 ` Joe Perches
2017-12-07 20:56 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207065554.GA19722@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.