From: Jeff Layton <jlayton@kernel.org>
To: akpm@linux-foundation.org
Cc: lustre-devel@lists.lustre.org, anton@tuxera.com,
andreas.dilger@intel.com, oleg.drokin@intel.com,
jsimmons@infradead.org, mikulas@artax.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: [RESEND][PATCH 3/3] hpfs: don't bother with the i_version counter or f_version
Date: Thu, 7 Dec 2017 06:32:06 -0500 [thread overview]
Message-ID: <20171207113206.31544-4-jlayton@kernel.org> (raw)
In-Reply-To: <20171207113206.31544-1-jlayton@kernel.org>
From: Jeff Layton <jlayton@redhat.com>
HPFS does not set SB_I_VERSION and does not use the i_version counter
internally.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/hpfs/dir.c | 1 -
fs/hpfs/dnode.c | 2 --
fs/hpfs/super.c | 1 -
3 files changed, 4 deletions(-)
diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c
index 8d6b7e35faf9..c83ece7facc5 100644
--- a/fs/hpfs/dir.c
+++ b/fs/hpfs/dir.c
@@ -150,7 +150,6 @@ static int hpfs_readdir(struct file *file, struct dir_context *ctx)
if (unlikely(ret < 0))
goto out;
ctx->pos = ((loff_t) hpfs_de_as_down_as_possible(inode->i_sb, hpfs_inode->i_dno) << 4) + 1;
- file->f_version = inode->i_version;
}
next_pos = ctx->pos;
if (!(de = map_pos_dirent(inode, &next_pos, &qbh))) {
diff --git a/fs/hpfs/dnode.c b/fs/hpfs/dnode.c
index 3b834563b1f1..a4ad18afbdec 100644
--- a/fs/hpfs/dnode.c
+++ b/fs/hpfs/dnode.c
@@ -419,7 +419,6 @@ int hpfs_add_dirent(struct inode *i,
c = 1;
goto ret;
}
- i->i_version++;
c = hpfs_add_to_dnode(i, dno, name, namelen, new_de, 0);
ret:
return c;
@@ -726,7 +725,6 @@ int hpfs_remove_dirent(struct inode *i, dnode_secno dno, struct hpfs_dirent *de,
return 2;
}
}
- i->i_version++;
for_all_poss(i, hpfs_pos_del, (t = get_pos(dnode, de)) + 1, 1);
hpfs_delete_de(i->i_sb, dnode, de);
hpfs_mark_4buffers_dirty(qbh);
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index c45a3b9b9ac7..f2c3ebcd309c 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -235,7 +235,6 @@ static struct inode *hpfs_alloc_inode(struct super_block *sb)
ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
if (!ei)
return NULL;
- ei->vfs_inode.i_version = 1;
return &ei->vfs_inode;
}
--
2.14.3
next prev parent reply other threads:[~2017-12-07 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 11:32 [RESEND][PATCH 0/3] fs: remove unnecessary i_version handling from various filesystems Jeff Layton
2017-12-07 11:32 ` [RESEND][PATCH 1/3] lustre: don't set f_version in ll_readdir Jeff Layton
2017-12-07 11:32 ` [RESEND][PATCH 2/3] ntfs: remove i_version handling Jeff Layton
2017-12-07 11:32 ` Jeff Layton [this message]
2017-12-07 11:40 ` [RESEND][PATCH 0/3] fs: remove unnecessary i_version handling from various filesystems Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207113206.31544-4-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andreas.dilger@intel.com \
--cc=anton@tuxera.com \
--cc=jsimmons@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=lustre-devel@lists.lustre.org \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.