From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4.14,32/75] usb: dwc2: Fix UDC state tracking From: Greg Kroah-Hartman Message-Id: <20171207130820.064355907@linuxfoundation.org> Date: Thu, 7 Dec 2017 14:07:54 +0100 To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin List-ID: NC4xNC1zdGFibGUgcmV2aWV3IHBhdGNoLiAgSWYgYW55b25lIGhhcyBhbnkgb2JqZWN0aW9ucywg cGxlYXNlIGxldCBtZSBrbm93LgoKLS0tLS0tLS0tLS0tLS0tLS0tCgpGcm9tOiBKb2huIFN0dWx0 eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KCgpbIFVwc3RyZWFtIGNvbW1pdCBjZTJiMjFhNGU1 Y2UwNDJjMGE0MmM5ZGI4ZmE5ZTBmODQ5NDI3ZDVlIF0KCkl0IGhhcyBiZWVuIG5vdGljZWQgdGhh dCB0aGUgZHdjMiB1ZGMgc3RhdGUgcmVwb3J0aW5nIGRvZXNuJ3QKc2VlbSB0byB3b3JrIChhdCBs ZWFzdCBvbiBIaUtleSBib2FyZHMpLiBXaGVyZSBhZnRlciB0aGUgaW5pdGlhbApzZXR1cCwgdGhl IHN5c2ZzIC9zeXMvY2xhc3MvdWRjL2Y3MmMwMDAwLnVzYi9zdGF0ZSBmaWxlIHdvdWxkCnJlcG9y dCAiY29uZmlndXJlZCIgbm8gbWF0dGVyIHRoZSBzdGF0ZSBvZiB0aGUgT1RHIHBvcnQuCgpUaGlz IHBhdGNoIGFkZHMgYSBjYWxsIHNvIHRoYXQgd2UgcmVwb3J0IHRvIHRoZSBVREMgbGF5ZXIgd2hl bgp0aGUgZ2FkZ2V0IGRldmljZSBpcyBkaXNjb25uZWN0ZWQuCgpUaGlzIHBhdGNoIGRvZXMgZGVw ZW5kIG9uIHRoZSBwcmV2aW91cyBwYXRjaCAoInVzYjogZHdjMjoKSW1wcm92ZSBnYWRnZXQgc3Rh dGUgZGlzY29ubmVjdGlvbiBoYW5kbGluZyIpIGluIHRoaXMgcGF0Y2ggc2V0CmluIG9yZGVyIHRv IHByb3Blcmx5IHdvcmsuCgpDYzogV2VpIFh1IDx4dXdlaTVAaGlzaWxpY29uLmNvbT4KQ2M6IEd1 b2RvbmcgWHUgPGd1b2RvbmcueHVAbGluYXJvLm9yZz4KQ2M6IEFtaXQgUHVuZGlyIDxhbWl0LnB1 bmRpckBsaW5hcm8ub3JnPgpDYzogWW9uZ1FpbiBMaXUgPHlvbmdxaW4ubGl1QGxpbmFyby5vcmc+ CkNjOiBKb2huIFlvdW4gPGpvaG55b3VuQHN5bm9wc3lzLmNvbT4KQ2M6IE1pbmFzIEhhcnV0eXVu eWFuIDxNaW5hcy5IYXJ1dHl1bnlhbkBzeW5vcHN5cy5jb20+CkNjOiBEb3VnbGFzIEFuZGVyc29u IDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+CkNjOiBDaGVuIFl1IDxjaGVueXU1NkBodWF3ZWkuY29t PgpDYzogRmVsaXBlIEJhbGJpIDxmZWxpcGUuYmFsYmlAbGludXguaW50ZWwuY29tPgpDYzogR3Jl ZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KQ2M6IGxpbnV4LXVz YkB2Z2VyLmtlcm5lbC5vcmcKQWNrZWQtYnk6IE1pbmFzIEhhcnV0eXVueWFuIDxobWluYXNAc3lu b3BzeXMuY29tPgpUZXN0ZWQtYnk6IE1pbmFzIEhhcnV0eXVueWFuIDxobWluYXNAc3lub3BzeXMu Y29tPgpSZXBvcnRlZC1ieTogQW1pdCBQdW5kaXIgPGFtaXQucHVuZGlyQGxpbmFyby5vcmc+ClNp Z25lZC1vZmYtYnk6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgpTaWduZWQt b2ZmLWJ5OiBGZWxpcGUgQmFsYmkgPGZlbGlwZS5iYWxiaUBsaW51eC5pbnRlbC5jb20+ClNpZ25l ZC1vZmYtYnk6IFNhc2hhIExldmluIDxhbGV4YW5kZXIubGV2aW5AdmVyaXpvbi5jb20+ClNpZ25l ZC1vZmYtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+ Ci0tLQogZHJpdmVycy91c2IvZHdjMi9nYWRnZXQuYyB8ICAgIDIgKysKIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKykKCgoKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNl bmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNz YWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAg aHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCgotLS0gYS9kcml2ZXJz L3VzYi9kd2MyL2dhZGdldC5jCisrKyBiL2RyaXZlcnMvdXNiL2R3YzIvZ2FkZ2V0LmMKQEAgLTMy MDIsNiArMzIwMiw4IEBAIHZvaWQgZHdjMl9oc290Z19kaXNjb25uZWN0KHN0cnVjdCBkd2MyX2gK IAogCWNhbGxfZ2FkZ2V0KGhzb3RnLCBkaXNjb25uZWN0KTsKIAloc290Zy0+bHhfc3RhdGUgPSBE V0MyX0wzOworCisJdXNiX2dhZGdldF9zZXRfc3RhdGUoJmhzb3RnLT5nYWRnZXQsIFVTQl9TVEFU RV9OT1RBVFRBQ0hFRCk7CiB9CiAKIC8qKgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755118AbdLGNbA (ORCPT ); Thu, 7 Dec 2017 08:31:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34252 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755410AbdLGNLN (ORCPT ); Thu, 7 Dec 2017 08:11:13 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin Subject: [PATCH 4.14 32/75] usb: dwc2: Fix UDC state tracking Date: Thu, 7 Dec 2017 14:07:54 +0100 Message-Id: <20171207130820.064355907@linuxfoundation.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171207130818.742746317@linuxfoundation.org> References: <20171207130818.742746317@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: John Stultz [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] It has been noticed that the dwc2 udc state reporting doesn't seem to work (at least on HiKey boards). Where after the initial setup, the sysfs /sys/class/udc/f72c0000.usb/state file would report "configured" no matter the state of the OTG port. This patch adds a call so that we report to the UDC layer when the gadget device is disconnected. This patch does depend on the previous patch ("usb: dwc2: Improve gadget state disconnection handling") in this patch set in order to properly work. Cc: Wei Xu Cc: Guodong Xu Cc: Amit Pundir Cc: YongQin Liu Cc: John Youn Cc: Minas Harutyunyan Cc: Douglas Anderson Cc: Chen Yu Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Acked-by: Minas Harutyunyan Tested-by: Minas Harutyunyan Reported-by: Amit Pundir Signed-off-by: John Stultz Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/usb/dwc2/gadget.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -3202,6 +3202,8 @@ void dwc2_hsotg_disconnect(struct dwc2_h call_gadget(hsotg, disconnect); hsotg->lx_state = DWC2_L3; + + usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED); } /**