From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Refactor common list iteration over GGTT vma
Date: Thu, 7 Dec 2017 19:05:52 +0200 [thread overview]
Message-ID: <20171207170552.GK10981@intel.com> (raw)
In-Reply-To: <151266519713.25422.4447886735340141588@mail.alporthouse.com>
On Thu, Dec 07, 2017 at 04:46:37PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjälä (2017-12-07 16:40:49)
> > On Thu, Dec 07, 2017 at 04:27:17PM +0000, Chris Wilson wrote:
> > > +#define for_each_ggtt_vma(V, OBJ) \
> > > + list_for_each_entry(V, &(OBJ)->vma_list, obj_link) \
> > > + if (!i915_vma_is_ggtt(vma)) break; else
> >
> > for_each_if() ?
>
> for_each_if() doesn't perform a break.
Ah. I probably should have read the comment :)
>
> for_each_until() ? I think that may be a bit too magical.
Maybe. I guess open coding it here is fine until the pattern
starts to repeat all over the place.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-07 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 16:27 [PATCH] drm/i915: Refactor common list iteration over GGTT vma Chris Wilson
2017-12-07 16:40 ` Ville Syrjälä
2017-12-07 16:46 ` Chris Wilson
2017-12-07 17:05 ` Ville Syrjälä [this message]
2017-12-07 16:48 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-07 17:49 ` [PATCH] " Daniel Vetter
2017-12-07 21:11 ` [PATCH v2] " Chris Wilson
2017-12-07 21:14 ` [PATCH v3] " Chris Wilson
2017-12-07 21:46 ` ✓ Fi.CI.BAT: success for drm/i915: Refactor common list iteration over GGTT vma (rev3) Patchwork
2017-12-07 21:56 ` ✗ Fi.CI.IGT: failure for drm/i915: Refactor common list iteration over GGTT vma Patchwork
2017-12-08 0:32 ` ✗ Fi.CI.IGT: warning for drm/i915: Refactor common list iteration over GGTT vma (rev3) Patchwork
2017-12-08 0:44 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207170552.GK10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.