All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [rdma-rc] iw_cxgb4: only clear the ARMED bit if a notification is needed
Date: Thu, 7 Dec 2017 14:16:37 -0700	[thread overview]
Message-ID: <20171207211637.GA9479@ziepe.ca> (raw)
In-Reply-To: <20171201213130.1ED79E0C84-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>

On Thu, Nov 30, 2017 at 09:41:56AM -0800, Steve Wise wrote:
> In __flush_qp(), the CQ ARMED bit was being cleared regardless of
> whether any notification is actually needed.  This resulted in the iser
> termination logic getting stuck in ib_drain_sq() because the CQ was not
> marked ARMED and thus the drain CQE notification wasn't triggered.
> 
> This new bug was exposed when this commit was merged:
> 
> commit cbb40fadd31c ("iw_cxgb4: only call the cq comp_handler when the
> cq is armed")
> 
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>  drivers/infiniband/hw/cxgb4/qp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to -rc, thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-12-07 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 17:41 [PATCH rdma-rc] iw_cxgb4: only clear the ARMED bit if a notification is needed Steve Wise
     [not found] ` <20171201213130.1ED79E0C84-/5N3P9jjx0xzbRFIqnYvSA@public.gmane.org>
2017-12-07 21:16   ` Jason Gunthorpe [this message]
     [not found]     ` <20171207211637.GA9479-uk2M96/98Pc@public.gmane.org>
2017-12-11 16:12       ` [rdma-rc] " Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171207211637.GA9479@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.