Re: [PATCH v3 nf-next] netfilter: connlimit: split xt_connlimit into front/backend

[Florian Westphal <fw@strlen.de>]

Yi-Hung Wei <yihung.wei@gmail.com> wrote:
> On Wed, Dec 6, 2017 at 4:41 AM, Florian Westphal <fw@strlen.de> wrote:
> > +static int __init nf_conncount_modinit(void)
> > +{
> > +       int ret, i;
> > +
> > +       BUILD_BUG_ON(CONNCOUNT_LOCK_SLOTS > CONNCOUNT_SLOTS);
> > +       BUILD_BUG_ON((CONNCOUNT_SLOTS % CONNCOUNT_LOCK_SLOTS) != 0);
> > +
> > +       return ret;
> I test it with iptables -m connlimit, and nf_conncount may fail to
> load sometimes.
> 
> It turns out that it is because ret is not used in this function.
> Shall we get rid of ret, and return 0 here?

Yes.