All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Liu, Yi L" <yi.l.liu@linux.intel.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] intel_iommu: fix error param in string
Date: Fri, 8 Dec 2017 14:52:06 +0800	[thread overview]
Message-ID: <20171208065206.GB2392@sky-dev> (raw)
In-Reply-To: <20171208042654.10910-3-peterx@redhat.com>

Looks good.

Reviewed-by: Liu, Yi L <yi.l.liu@intel.com>

On Fri, Dec 08, 2017 at 12:26:54PM +0800, Peter Xu wrote:
> It should be caching-mode.  It may confuse people when it pops up.
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  hw/i386/intel_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index c1fa08d205..fe15d3ba84 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2327,7 +2327,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
>      IntelIOMMUNotifierNode *next_node = NULL;
>  
>      if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
> -        error_report("We need to set cache_mode=1 for intel-iommu to enable "
> +        error_report("We need to set caching-mode=1 for intel-iommu to enable "
>                       "device assignment with IOMMU protection.");
>          exit(1);
>      }
> -- 
> 2.14.3
> 
> 

  reply	other threads:[~2017-12-08  7:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08  4:26 [Qemu-devel] [PATCH 0/2] vtd: tiny fixes for 2.12 Peter Xu
2017-12-08  4:26 ` [Qemu-devel] [PATCH 1/2] intel_iommu: remove X86_IOMMU_PCI_DEVFN_MAX Peter Xu
2017-12-08  6:50   ` Liu, Yi L
2017-12-08  4:26 ` [Qemu-devel] [PATCH 2/2] intel_iommu: fix error param in string Peter Xu
2017-12-08  6:52   ` Liu, Yi L [this message]
2017-12-20  3:16 ` [Qemu-devel] [PATCH 0/2] vtd: tiny fixes for 2.12 Peter Xu
2017-12-20  8:43 ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208065206.GB2392@sky-dev \
    --to=yi.l.liu@linux.intel.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.