From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 09/12] syscalls/mount03: Copy setuid_test to execute instead of 'TEST FILE'
Date: Fri, 8 Dec 2017 12:37:42 +0100 [thread overview]
Message-ID: <20171208113741.GE13286@rei> (raw)
In-Reply-To: <87vahhv64c.fsf@e105922-lin.cambridge.arm.com>
Hi!
> Apologies for not being more specific. We do it twice because in the
> quoted text you say (emphasis mine) -
>
> "it should be done _once_ in the test setup _as well as_ the code that
> sets the actual setuid bit."
>
> I took that to mean that you're asking for the file to be copied in
> setup() as well as in the code before it gets used. Obviously I've
> misunderstood your statement. What are you actually suggesting there?
Ah, that's where the misunderstanding happened, "the code that sets the
actual setuid bit" == chmod(file, SUID_MODE);
I was trying to state that the actual test setup that could be done only
once should be put into the test setup.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-12-08 11:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 16:36 [LTP] [PATCH v3 00/12] Collection of fixes Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 01/12] Move check_hugepage() helper to mem/lib Punit Agrawal
2017-12-05 8:52 ` Petr Vorel
2017-12-04 16:36 ` [LTP] [PATCH v3 02/12] thp: ensure hugetlbfs is available Punit Agrawal
2017-12-05 8:53 ` Petr Vorel
2017-12-04 16:36 ` [LTP] [PATCH v3 03/12] hugeshmctl01: Convert to LTP synchronisation primitives Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 04/12] hugeshmctl01: Fix warning about signed/unsigned comparison Punit Agrawal
2017-12-05 9:50 ` Petr Vorel
2017-12-04 16:36 ` [LTP] [PATCH v3 05/12] hugeshmctl02: Fix allocation size for odd number of hugepages Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 06/12] hugeshmget02: add missing SHM_HUGETLB flag on segment creation Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 07/12] sigwaitinfo01: fix race between sending and dequeueing RT signals Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 08/12] sigwaitinfo01: catch SEGV and report success for bad_address2 testcase Punit Agrawal
2017-12-08 10:28 ` Cyril Hrubis
2017-12-08 11:49 ` Punit Agrawal
2017-12-08 12:09 ` Cyril Hrubis
2017-12-04 16:36 ` [LTP] [PATCH v3 09/12] syscalls/mount03: Copy setuid_test to execute instead of 'TEST FILE' Punit Agrawal
2017-12-08 10:26 ` Cyril Hrubis
2017-12-08 10:39 ` Punit Agrawal
2017-12-08 10:43 ` Cyril Hrubis
2017-12-08 10:58 ` Punit Agrawal
2017-12-08 11:37 ` Cyril Hrubis [this message]
2017-12-08 11:50 ` Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 10/12] getdtablesize01: Handle ENFILE errno Punit Agrawal
2017-12-08 10:27 ` Cyril Hrubis
2017-12-08 10:41 ` Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 11/12] perf_event_open: Handle absence of PMU gracefully Punit Agrawal
2017-12-04 16:36 ` [LTP] [PATCH v3 12/12] hotplug/cpu_hotplug: Remove bashism disown from kill_pid() Punit Agrawal
2017-12-05 8:21 ` Petr Vorel
2017-12-05 10:20 ` Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208113741.GE13286@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.