From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Date: Fri, 8 Dec 2017 13:44:04 +0200 Message-ID: <20171208114404.GN10981@intel.com> References: <20171208093323.2212-1-augustine.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171208093323.2212-1-augustine.chen@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Augustine.Chen" Cc: Juergen Gross , Dou Liyang , alsa-devel@alsa-project.org, tiwai@suse.de, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Jiang Liu , pierre-louis.bossart@intel.com List-Id: alsa-devel@alsa-project.org T24gRnJpLCBEZWMgMDgsIDIwMTcgYXQgMDU6MzM6MjNQTSArMDgwMCwgQXVndXN0aW5lLkNoZW4g d3JvdGU6Cj4gVGhlIGNoaXAgZGF0YSBvZiBIRE1JIExQRSBhdWRpbyBpcyBzZXQgdG8gZHJtX2k5 MTVfcHJpdmF0ZSB3aGljaCBpcyBub3QKPiBjb25zaXN0ZW50IHdpdGggdGhlIGV4cGVjdGF0aW9u IGJ5IHg4NiBBUElDIGRyaXZlci4KCkhtbS4gV2h5IGlzIHRoZSBhcGljIGNvZGUgbG9va2luZyBh dCBkYXRhIGZvciBhbiBpcnEgY2hpcCBpdApoYXNuJ3QgY3JlYXRlZD8KCkRvIHdlIG5lZWQgc29t ZXRoaW5nIGxpa2UKLSBkZXZfcHJpdi0+bHBlX2F1ZGlvLmlycSA9IGlycV9hbGxvY19kZXNjKDAp OworIGRldl9wcml2LT5scGVfYXVkaW8uaXJxID0gaXJxX2FsbG9jX2Rlc2MoLTEpOwo/CgpUaGF0 ICpsb29rcyogbW9yZSBjb3JyZWN0IHRvIG1lIGJhc2VkIG9uIGEgY3Vyc29yeSBnbGFuY2UgYXQg dGhlIHg4Ngpjb2RlLCBidXQgSSBkaWRuJ3QgdHJhd2wgdmVyeSBkZWVwbHkuCgo+IEluIHRoZSBj YXNlIG9mIG5vdAo+IGVuYWJsaW5nIENPTkZJR19DUFVNQVNLX09GRlNUQUNLLCB0aGlzIHdvdWxk IGNhdXNlIGtlcm5lbCBwYW5pYyB3aGlsZSBkb2luZwo+IENQVSBob3RwbHVnLiBTaW5jZSB0aGUg ZGVwZW5kZW5jeSBvZiBJUlEgY2hpcCBkYXRhIHdhcyByZW1vdmVkIGZyb20gSERNSQo+IExQRSBh dWRpbyBieSBDb21taXQgOWJkOTU5MDk5N2I5MmZiZDc5ZmQwMjhmNzA0ZjZjNTg0YjQ0MzlkNyAo ImRybS9pOTE1Ogo+IFN0b3AgcHJldGVuZGluZyB0byBtYXNrL3VubWFzayBMUEUgYXVkaW8gaW50 ZXJydXB0cyIpLCByZW1vdmUgdGhlCj4gY29kZSBvZiBzZXR0aW5nIElSUSBjaGlwIGRhdGEgdG8g cmVzb2x2ZSB0aGlzIGlzc3VlLgo+IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0 b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM3MzEKPiBDYzogUGllcnJlLUxvdWlzIEJvc3NhcnQg PHBpZXJyZS1sb3Vpcy5ib3NzYXJ0QGludGVsLmNvbT4KPiBDYzogSmVyb21lIEFuYW5kIDxqZXJv bWUuYW5hbmRAaW50ZWwuY29tPgo+IENjOiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+Cj4g U2lnbmVkLW9mZi1ieTogQXVndXN0aW5lLkNoZW4gPGF1Z3VzdGluZS5jaGVuQGludGVsLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHBlX2F1ZGlvLmMgfCAyICstCj4g IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scGVfYXVkaW8uYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xwZV9hdWRpby5jCj4gaW5kZXggM2JmNjUyOC4uNTYxNzZmOSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scGVfYXVkaW8uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xwZV9hdWRpby5jCj4gQEAgLTE3Niw3ICsx NzYsNyBAQCBzdGF0aWMgaW50IGxwZV9hdWRpb19pcnFfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gIAkJCQloYW5kbGVfc2ltcGxlX2lycSwKPiAgCQkJCSJoZG1pX2xw ZV9hdWRpb19pcnFfaGFuZGxlciIpOwo+ICAKPiAtCXJldHVybiBpcnFfc2V0X2NoaXBfZGF0YShp cnEsIGRldl9wcml2KTsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbCBscGVf YXVkaW9fZGV0ZWN0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtLSAKPiAx LjkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbdLHLoM (ORCPT ); Fri, 8 Dec 2017 06:44:12 -0500 Received: from mga03.intel.com ([134.134.136.65]:52978 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbdLHLoK (ORCPT ); Fri, 8 Dec 2017 06:44:10 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,377,1508828400"; d="scan'208";a="11674294" Date: Fri, 8 Dec 2017 13:44:04 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Augustine.Chen" Cc: intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org, jerome.anand@intel.com, pierre-louis.bossart@intel.com, tiwai@suse.de, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Jiang Liu , Juergen Gross , Dou Liyang , linux-kernel@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Message-ID: <20171208114404.GN10981@intel.com> References: <20171208093323.2212-1-augustine.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171208093323.2212-1-augustine.chen@intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote: > The chip data of HDMI LPE audio is set to drm_i915_private which is not > consistent with the expectation by x86 APIC driver. Hmm. Why is the apic code looking at data for an irq chip it hasn't created? Do we need something like - dev_priv->lpe_audio.irq = irq_alloc_desc(0); + dev_priv->lpe_audio.irq = irq_alloc_desc(-1); ? That *looks* more correct to me based on a cursory glance at the x86 code, but I didn't trawl very deeply. > In the case of not > enabling CONFIG_CPUMASK_OFFSTACK, this would cause kernel panic while doing > CPU hotplug. Since the dependency of IRQ chip data was removed from HDMI > LPE audio by Commit 9bd9590997b92fbd79fd028f704f6c584b4439d7 ("drm/i915: > Stop pretending to mask/unmask LPE audio interrupts"), remove the > code of setting IRQ chip data to resolve this issue. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103731 > Cc: Pierre-Louis Bossart > Cc: Jerome Anand > Cc: Takashi Iwai > Signed-off-by: Augustine.Chen > --- > drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c > index 3bf6528..56176f9 100644 > --- a/drivers/gpu/drm/i915/intel_lpe_audio.c > +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c > @@ -176,7 +176,7 @@ static int lpe_audio_irq_init(struct drm_i915_private *dev_priv) > handle_simple_irq, > "hdmi_lpe_audio_irq_handler"); > > - return irq_set_chip_data(irq, dev_priv); > + return 0; > } > > static bool lpe_audio_detect(struct drm_i915_private *dev_priv) > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC