From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>
Subject: Re: [PATCH] perf tests: Handle properly readdir DT_UNKNOWN
Date: Fri, 8 Dec 2017 12:55:15 +0100 [thread overview]
Message-ID: <20171208115515.GD2799@krava> (raw)
In-Reply-To: <20171207151905.GC6458@kernel.org>
On Thu, Dec 07, 2017 at 12:19:05PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Dec 06, 2017 at 06:45:35PM +0100, Jiri Olsa escreveu:
> > Some system can return DT_UNKNOWN in readdir's struct dirent::d_type
> > and we must handle it properly. In this case we can directly check
> > if the entity we found is directory and skip it.
>
> > Making is_directory function global.
>
> Split this part into a prep patch and left with the previous paragraph
> the 'perf test' bits.
>
> [acme@jouet perf]$ git log --oneline -2
> de7cee586145 (HEAD -> perf/core, acme.korg/perf/core) perf test: Handle properly readdir DT_UNKNOWN
> ef87e1133606 perf utils: Move is_directory() to path.h
> [acme@jouet perf]$
thanks,
jirka
next prev parent reply other threads:[~2017-12-08 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 17:45 [PATCH] perf tests: Handle properly readdir DT_UNKNOWN Jiri Olsa
2017-12-07 15:19 ` Arnaldo Carvalho de Melo
2017-12-08 11:55 ` Jiri Olsa [this message]
2017-12-28 15:26 ` [tip:perf/core] perf utils: Move is_directory() to path.h tip-bot for Jiri Olsa
2017-12-28 15:27 ` [tip:perf/core] perf test: Handle properly readdir DT_UNKNOWN tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208115515.GD2799@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.