From: Greg KH <gregkh@linuxfoundation.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@codeaurora.org, robdclark@gmail.com, robin.murphy@arm.com,
will.deacon@arm.com, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers
Date: Fri, 8 Dec 2017 14:21:36 +0100 [thread overview]
Message-ID: <20171208132136.GA26631@kroah.com> (raw)
In-Reply-To: <1512736247-16538-1-git-send-email-vivek.gautam@codeaurora.org>
On Fri, Dec 08, 2017 at 06:00:47PM +0530, Vivek Gautam wrote:
> The device link allows the pm framework to tie the supplier and
> consumer. So, whenever the consumer is powered-on, the supplier
> is powered-on first.
>
> There are however cases in which the consumer wants to power-on
> the supplier, but not itself.
> E.g., A Graphics or multimedia driver wants to power-on the SMMU
> to unmap a buffer and finish the TLB operations without powering
> on itself. Some of these unmap requests are coming from the
> user space when the controller itself is not powered-up, and it
> can be huge penalty in terms of power and latency to power-up
> the graphics/mm controllers.
> There can be an argument that the supplier should handle this case
> on its own and there should not be a need for the consumer to
> power-on the supplier. But as discussed on the thread [1] about
> ARM-SMMU runtime pm, we don't want to introduce runtime pm calls
> in atomic paths, such as in arm_smmu_unmap.
>
> [1] https://patchwork.kernel.org/patch/9827825/
>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> drivers/base/power/runtime.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 027d159ac381..af169304ca13 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -1578,6 +1578,7 @@ void pm_runtime_get_suppliers(struct device *dev)
>
> device_links_read_unlock(idx);
> }
> +EXPORT_SYMBOL_GPL(pm_runtime_get_suppliers);
We do not export symbols unless there are in-kernel users of them.
Where is the patch that adds a user for these functions?
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-08 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 12:30 [PATCH 1/1] base: power: runtime: Export pm_runtime_get/put_suppliers Vivek Gautam
2017-12-08 13:21 ` Greg KH [this message]
2017-12-08 13:39 ` Vivek Gautam
2017-12-08 14:07 ` Rafael J. Wysocki
2017-12-08 17:03 ` Vivek Gautam
2018-01-03 12:01 ` Rafael J. Wysocki
2018-01-03 12:42 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208132136.GA26631@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sboyd@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.