From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol Date: Fri, 8 Dec 2017 15:30:28 +0100 Message-ID: <20171208143028.GZ21780@piout.net> References: <20171205101000.968887-1-arnd@arndb.de> <20171205105750.GI21780@piout.net> <20171205124707.GJ21780@piout.net> <20171205220759.GL21780@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by alsa0.perex.cz (Postfix) with ESMTP id 9BBCB267BC5 for ; Fri, 8 Dec 2017 15:30:58 +0100 (CET) Content-Disposition: inline In-Reply-To: <20171205220759.GL21780@piout.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Arnd Bergmann Cc: alsa-devel@alsa-project.org, Liam Girdwood , Linux Kernel Mailing List , Nicolas Ferre , Takashi Iwai , Mark Brown , Linux ARM List-Id: alsa-devel@alsa-project.org On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote: > On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > > wrote: > > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > > > Ok, does that solve both randconfigs? > > > > > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > > > index 4a56f3dfba51..dcee145dd179 100644 > > > --- a/sound/soc/atmel/Kconfig > > > +++ b/sound/soc/atmel/Kconfig > > > @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 > > > config SND_ATMEL_SOC_CLASSD > > > tristate "Atmel ASoC driver for boards using CLASSD" > > > depends on ARCH_AT91 || COMPILE_TEST > > > - select SND_ATMEL_SOC_DMA > > > + select SND_SOC_GENERIC_DMAENGINE_PCM > > > select REGMAP_MMIO > > > help > > > Say Y if you want to add support for Atmel ASoC driver for boards using > > > > Yes, that works as well and looks reliable. I've sent another > > follow-up now, working on the > > assumption that we actually need SND_ATMEL_SOC_DMA. > > > > Both patches make it build, but obviously only one of the two is > > actually correct. I assume you know what you are doing, so if > > you want to send your patch with a proper changelog, please add > > my > > > > Tested-by: Arnd Bergmann > > > > Ok, I'll test on a real board before the end of the week (I need to find > a speaker) and I'll send a proper patch. > So I've tested and this works properly, I've sent the patch (as you probably have seen). -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Fri, 8 Dec 2017 15:30:28 +0100 Subject: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol In-Reply-To: <20171205220759.GL21780@piout.net> References: <20171205101000.968887-1-arnd@arndb.de> <20171205105750.GI21780@piout.net> <20171205124707.GJ21780@piout.net> <20171205220759.GL21780@piout.net> Message-ID: <20171208143028.GZ21780@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote: > On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > > wrote: > > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > > > Ok, does that solve both randconfigs? > > > > > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > > > index 4a56f3dfba51..dcee145dd179 100644 > > > --- a/sound/soc/atmel/Kconfig > > > +++ b/sound/soc/atmel/Kconfig > > > @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 > > > config SND_ATMEL_SOC_CLASSD > > > tristate "Atmel ASoC driver for boards using CLASSD" > > > depends on ARCH_AT91 || COMPILE_TEST > > > - select SND_ATMEL_SOC_DMA > > > + select SND_SOC_GENERIC_DMAENGINE_PCM > > > select REGMAP_MMIO > > > help > > > Say Y if you want to add support for Atmel ASoC driver for boards using > > > > Yes, that works as well and looks reliable. I've sent another > > follow-up now, working on the > > assumption that we actually need SND_ATMEL_SOC_DMA. > > > > Both patches make it build, but obviously only one of the two is > > actually correct. I assume you know what you are doing, so if > > you want to send your patch with a proper changelog, please add > > my > > > > Tested-by: Arnd Bergmann > > > > Ok, I'll test on a real board before the end of the week (I need to find > a speaker) and I'll send a proper patch. > So I've tested and this works properly, I've sent the patch (as you probably have seen). -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754064AbdLHObA (ORCPT ); Fri, 8 Dec 2017 09:31:00 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:44146 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753875AbdLHOa7 (ORCPT ); Fri, 8 Dec 2017 09:30:59 -0500 Date: Fri, 8 Dec 2017 15:30:28 +0100 From: Alexandre Belloni To: Arnd Bergmann Cc: Nicolas Ferre , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Linux ARM , Linux Kernel Mailing List Subject: Re: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol Message-ID: <20171208143028.GZ21780@piout.net> References: <20171205101000.968887-1-arnd@arndb.de> <20171205105750.GI21780@piout.net> <20171205124707.GJ21780@piout.net> <20171205220759.GL21780@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171205220759.GL21780@piout.net> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote: > On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote: > > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni > > wrote: > > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote: > > > > > > Ok, does that solve both randconfigs? > > > > > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig > > > index 4a56f3dfba51..dcee145dd179 100644 > > > --- a/sound/soc/atmel/Kconfig > > > +++ b/sound/soc/atmel/Kconfig > > > @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731 > > > config SND_ATMEL_SOC_CLASSD > > > tristate "Atmel ASoC driver for boards using CLASSD" > > > depends on ARCH_AT91 || COMPILE_TEST > > > - select SND_ATMEL_SOC_DMA > > > + select SND_SOC_GENERIC_DMAENGINE_PCM > > > select REGMAP_MMIO > > > help > > > Say Y if you want to add support for Atmel ASoC driver for boards using > > > > Yes, that works as well and looks reliable. I've sent another > > follow-up now, working on the > > assumption that we actually need SND_ATMEL_SOC_DMA. > > > > Both patches make it build, but obviously only one of the two is > > actually correct. I assume you know what you are doing, so if > > you want to send your patch with a proper changelog, please add > > my > > > > Tested-by: Arnd Bergmann > > > > Ok, I'll test on a real board before the end of the week (I need to find > a speaker) and I'll send a proper patch. > So I've tested and this works properly, I've sent the patch (as you probably have seen). -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com