From: Darren Hart <dvhart@infradead.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
AceLan Kao <acelan.kao@canonical.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic
Date: Fri, 8 Dec 2017 15:48:03 -0800 [thread overview]
Message-ID: <20171208234803.GC14187@fury> (raw)
In-Reply-To: <7546133.vVTS3nG8Ku@pebbles>
On Sat, Dec 09, 2017 at 12:28:18AM +0100, Stefan Brüns wrote:
> On Saturday, December 9, 2017 12:07:08 AM CET Darren Hart (VMware) wrote:
> > The new notify_handler logic determining if autorelease should be used or
> > not is a bit awkward, and can result in more than one call to
> > sparse_keymap_report_event for the same event (scancode). The nesting
> > and long lines also made it difficult to read.
> >
> > Simplify the logic by eliminating a level of nesting with a goto and
> > always calculate autorelease and val so we can make a single call to
> > sparse_keymap_report_event.
> >
> > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> > Cc: Stefan Brüns <stefan.bruens@rwth-aachen.de>
> > Cc: AceLan Kao <acelan.kao@canonical.com>
> > ---
> > Note: This is based on top of Stefan's v2 patch series for intel-vbtn,
> > currently in my review-dvhart branch.
>
> Hi Darren,
>
> is this tree publically available?
Yes, in the tree listed in MAINTAINERS:
git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
which is actually an alias I should now update to:
git://git.infradead.org/linux-platform-drivers-x86.git
Note that the review-* branches exist for CI/CD tooling and will rebase often.
testing, fixes, and for-next are the only branches considered to be "published".
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-12-08 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 23:07 [PATCH] platform/x86: intel-vbtn: Simplify autorelease logic Darren Hart (VMware)
2017-12-08 23:28 ` Stefan Brüns
2017-12-08 23:28 ` Stefan Brüns
2017-12-08 23:48 ` Darren Hart [this message]
2017-12-11 1:48 ` Stefan Brüns
2017-12-11 1:48 ` Stefan Brüns
2017-12-12 0:31 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208234803.GC14187@fury \
--to=dvhart@infradead.org \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.