From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4.4,13/49] usb: dwc2: Fix UDC state tracking From: Greg Kroah-Hartman Message-Id: <20171209171256.GG27604@kroah.com> Date: Sat, 9 Dec 2017 18:12:56 +0100 To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin List-ID: T24gRnJpLCBEZWMgMDgsIDIwMTcgYXQgMDM6Mzc6MTdBTSArMDAwMCwgQmVuIEh1dGNoaW5ncyB3 cm90ZToKPiBPbiBUaHUsIDIwMTctMTItMDcgYXQgMTQ6MDcgKzAxMDAsIEdyZWcgS3JvYWgtSGFy dG1hbiB3cm90ZToKPiA+IDQuNC1zdGFibGUgcmV2aWV3IHBhdGNoLsKgwqBJZiBhbnlvbmUgaGFz IGFueSBvYmplY3Rpb25zLCBwbGVhc2UgbGV0IG1lCj4gPiBrbm93Lgo+ID4gCj4gPiAtLS0tLS0t LS0tLS0tLS0tLS0KPiA+IAo+ID4gRnJvbTogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFy by5vcmc+Cj4gPiAKPiA+IAo+ID4gWyBVcHN0cmVhbSBjb21taXQgY2UyYjIxYTRlNWNlMDQyYzBh NDJjOWRiOGZhOWUwZjg0OTQyN2Q1ZSBdCj4gPiAKPiA+IEl0IGhhcyBiZWVuIG5vdGljZWQgdGhh dCB0aGUgZHdjMiB1ZGMgc3RhdGUgcmVwb3J0aW5nIGRvZXNuJ3QKPiA+IHNlZW0gdG8gd29yayAo YXQgbGVhc3Qgb24gSGlLZXkgYm9hcmRzKS4gV2hlcmUgYWZ0ZXIgdGhlIGluaXRpYWwKPiA+IHNl dHVwLCB0aGUgc3lzZnMgL3N5cy9jbGFzcy91ZGMvZjcyYzAwMDAudXNiL3N0YXRlIGZpbGUgd291 bGQKPiA+IHJlcG9ydCAiY29uZmlndXJlZCIgbm8gbWF0dGVyIHRoZSBzdGF0ZSBvZiB0aGUgT1RH IHBvcnQuCj4gPiAKPiA+IFRoaXMgcGF0Y2ggYWRkcyBhIGNhbGwgc28gdGhhdCB3ZSByZXBvcnQg dG8gdGhlIFVEQyBsYXllciB3aGVuCj4gPiB0aGUgZ2FkZ2V0IGRldmljZSBpcyBkaXNjb25uZWN0 ZWQuCj4gPiAKPiA+IFRoaXMgcGF0Y2ggZG9lcyBkZXBlbmQgb24gdGhlIHByZXZpb3VzIHBhdGNo ICgidXNiOiBkd2MyOgo+ID4gSW1wcm92ZSBnYWRnZXQgc3RhdGUgZGlzY29ubmVjdGlvbiBoYW5k bGluZyIpIGluIHRoaXMgcGF0Y2ggc2V0Cj4gPiBpbiBvcmRlciB0byBwcm9wZXJseSB3b3JrLgo+ IAo+IFRoZW4geW91IHNob3VsZCBhZGQgdGhhdCAoY29tbWl0IGQyNDcxZDRhMjRkZikuCgpBaCwg YnV0IHRoYXQgcGF0Y2ggZG9lc24ndCBhcHBseSA6KAoKU28sIEkndmUgZHJvcHBlZCB0aGlzIG9u ZSwgYW5kIHRoZSBvbmUgYWZ0ZXIgdGhpcyBvbmUgKHdoaWNoIGRlcGVuZGVkIG9uCnRoaXMgb25l KSwgc28gYWxsIHNob3VsZCBiZSBiYWNrIHRvIGhvdyB0aGluZ3Mgd2VyZS4KClNhc2hhLCBjYW4g eW91IGZpeCB0aGlzIHVwIGFuZCBzdWJtaXQgYWxsIDMgZm9yIHRoZSA0LjQsIDQuOSBhbmQgNC4x NAp0cmVlcyBzb21ldGltZSBpbiB0aGUgZnV0dXJlPwoKdGhhbmtzLAoKZ3JlZyBrLWgKLS0tClRv IHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBs aW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJu ZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFq b3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751492AbdLIRMx (ORCPT ); Sat, 9 Dec 2017 12:12:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:49162 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbdLIRMt (ORCPT ); Sat, 9 Dec 2017 12:12:49 -0500 Date: Sat, 9 Dec 2017 18:12:56 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin Subject: Re: [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking Message-ID: <20171209171256.GG27604@kroah.com> References: <20171207124703.742654162@linuxfoundation.org> <20171207124705.660131394@linuxfoundation.org> <1512704237.18523.221.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512704237.18523.221.camel@codethink.co.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2017 at 03:37:17AM +0000, Ben Hutchings wrote: > On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.  If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: John Stultz > > > > > > [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] > > > > It has been noticed that the dwc2 udc state reporting doesn't > > seem to work (at least on HiKey boards). Where after the initial > > setup, the sysfs /sys/class/udc/f72c0000.usb/state file would > > report "configured" no matter the state of the OTG port. > > > > This patch adds a call so that we report to the UDC layer when > > the gadget device is disconnected. > > > > This patch does depend on the previous patch ("usb: dwc2: > > Improve gadget state disconnection handling") in this patch set > > in order to properly work. > > Then you should add that (commit d2471d4a24df). Ah, but that patch doesn't apply :( So, I've dropped this one, and the one after this one (which depended on this one), so all should be back to how things were. Sasha, can you fix this up and submit all 3 for the 4.4, 4.9 and 4.14 trees sometime in the future? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 9 Dec 2017 18:12:56 +0100 From: Greg Kroah-Hartman To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin Subject: Re: [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking Message-ID: <20171209171256.GG27604@kroah.com> References: <20171207124703.742654162@linuxfoundation.org> <20171207124705.660131394@linuxfoundation.org> <1512704237.18523.221.camel@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1512704237.18523.221.camel@codethink.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, Dec 08, 2017 at 03:37:17AM +0000, Ben Hutchings wrote: > On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch.��If anyone has any objections, please let me > > know. > > > > ------------------ > > > > From: John Stultz > > > > > > [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] > > > > It has been noticed that the dwc2 udc state reporting doesn't > > seem to work (at least on HiKey boards). Where after the initial > > setup, the sysfs /sys/class/udc/f72c0000.usb/state file would > > report "configured" no matter the state of the OTG port. > > > > This patch adds a call so that we report to the UDC layer when > > the gadget device is disconnected. > > > > This patch does depend on the previous patch ("usb: dwc2: > > Improve gadget state disconnection handling") in this patch set > > in order to properly work. > > Then you should add that (commit d2471d4a24df). Ah, but that patch doesn't apply :( So, I've dropped this one, and the one after this one (which depended on this one), so all should be back to how things were. Sasha, can you fix this up and submit all 3 for the 4.4, 4.9 and 4.14 trees sometime in the future? thanks, greg k-h