From: Pavel Machek <pavel@ucw.cz>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] mac80211: fix locking in ieee80211_sta_tear_down_BA_sessions
Date: Sun, 10 Dec 2017 09:36:11 +0100 [thread overview]
Message-ID: <20171210083611.GA3742@amd> (raw)
In-Reply-To: <20171209201338.24931-1-johannes@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
On Sat 2017-12-09 21:13:38, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Due to overlap between
> commit 1281103770e9 ("mac80211: Simplify locking in ieee80211_sta_tear_down_BA_sessions()")
> and the way that Luca modified
> commit 72e2c3438ba3 ("mac80211: tear down RX aggregations first")
> when sending it upstream from Intel's internal tree, we get
> the following warning:
>
> WARNING: CPU: 0 PID: 5472 at net/mac80211/agg-tx.c:315 ___ieee80211_stop_tx_ba_session+0x158/0x1f0
>
> since there's no appropriate locking around the call to
> ___ieee80211_stop_tx_ba_session; Sara's original just had
> a call to the locked __ieee80211_stop_tx_ba_session (one
> less underscore) but it looks like Luca modified both of
> the calls when fixing it up for upstream, leading to the
> problem at hand.
>
> Move the locking appropriately to fix this problem.
>
> Reported-by: Kalle Valo <kvalo@codeaurora.org>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2017-12-10 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 20:13 [PATCH] mac80211: fix locking in ieee80211_sta_tear_down_BA_sessions Johannes Berg
2017-12-10 8:36 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171210083611.GA3742@amd \
--to=pavel@ucw.cz \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.