From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: [PATCH v1] usb: phy: tegra: Increase PHY clock stabilization timeout Date: Mon, 11 Dec 2017 01:55:35 +0300 Message-ID: <20171210225535.8532-1-digetx@gmail.com> Return-path: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi , Jonathan Hunter , Thierry Reding Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org This fixes "utmi_phy_clk_enable: timeout waiting for phy to stabilize" error message. Signed-off-by: Dmitry Osipenko --- drivers/usb/phy/phy-tegra-usb.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index f668bfb708d3..7d5db625f800 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include @@ -305,14 +305,9 @@ static int utmip_pad_power_off(struct tegra_usb_phy *phy) static int utmi_wait_register(void __iomem *reg, u32 mask, u32 result) { - unsigned long timeout = 2000; - do { - if ((readl(reg) & mask) == result) - return 0; - udelay(1); - timeout--; - } while (timeout); - return -1; + u32 tmp; + + return readl_poll_timeout(reg, tmp, (tmp & mask) == result, 1, 5000); } static void utmi_phy_clk_disable(struct tegra_usb_phy *phy) -- 2.15.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1] usb: phy: tegra: Increase PHY clock stabilization timeout From: Dmitry Osipenko Message-Id: <20171210225535.8532-1-digetx@gmail.com> Date: Mon, 11 Dec 2017 01:55:35 +0300 To: Felipe Balbi , Jonathan Hunter , Thierry Reding Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: VGhpcyBmaXhlcyAidXRtaV9waHlfY2xrX2VuYWJsZTogdGltZW91dCB3YWl0aW5nIGZvciBwaHkg dG8gc3RhYmlsaXplIgplcnJvciBtZXNzYWdlLgoKU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBl bmtvIDxkaWdldHhAZ21haWwuY29tPgotLS0KIGRyaXZlcnMvdXNiL3BoeS9waHktdGVncmEtdXNi LmMgfCAxMyArKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3BoeS9waHktdGVncmEtdXNi LmMgYi9kcml2ZXJzL3VzYi9waHkvcGh5LXRlZ3JhLXVzYi5jCmluZGV4IGY2NjhiZmI3MDhkMy4u N2Q1ZGI2MjVmODAwIDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9waHkvcGh5LXRlZ3JhLXVzYi5j CisrKyBiL2RyaXZlcnMvdXNiL3BoeS9waHktdGVncmEtdXNiLmMKQEAgLTE2LDcgKzE2LDcgQEAK ICNpbmNsdWRlIDxsaW51eC9leHBvcnQuaD4KICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KICNp bmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KLSNpbmNsdWRlIDxsaW51eC9pby5oPgor I2luY2x1ZGUgPGxpbnV4L2lvcG9sbC5oPgogI2luY2x1ZGUgPGxpbnV4L2dwaW8uaD4KICNpbmNs dWRlIDxsaW51eC9vZi5oPgogI2luY2x1ZGUgPGxpbnV4L29mX2RldmljZS5oPgpAQCAtMzA1LDE0 ICszMDUsOSBAQCBzdGF0aWMgaW50IHV0bWlwX3BhZF9wb3dlcl9vZmYoc3RydWN0IHRlZ3JhX3Vz Yl9waHkgKnBoeSkKIAogc3RhdGljIGludCB1dG1pX3dhaXRfcmVnaXN0ZXIodm9pZCBfX2lvbWVt ICpyZWcsIHUzMiBtYXNrLCB1MzIgcmVzdWx0KQogewotCXVuc2lnbmVkIGxvbmcgdGltZW91dCA9 IDIwMDA7Ci0JZG8gewotCQlpZiAoKHJlYWRsKHJlZykgJiBtYXNrKSA9PSByZXN1bHQpCi0JCQly ZXR1cm4gMDsKLQkJdWRlbGF5KDEpOwotCQl0aW1lb3V0LS07Ci0JfSB3aGlsZSAodGltZW91dCk7 Ci0JcmV0dXJuIC0xOworCXUzMiB0bXA7CisKKwlyZXR1cm4gcmVhZGxfcG9sbF90aW1lb3V0KHJl ZywgdG1wLCAodG1wICYgbWFzaykgPT0gcmVzdWx0LCAxLCA1MDAwKTsKIH0KIAogc3RhdGljIHZv aWQgdXRtaV9waHlfY2xrX2Rpc2FibGUoc3RydWN0IHRlZ3JhX3VzYl9waHkgKnBoeSkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752307AbdLJW6R (ORCPT ); Sun, 10 Dec 2017 17:58:17 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:37201 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbdLJW6M (ORCPT ); Sun, 10 Dec 2017 17:58:12 -0500 X-Google-Smtp-Source: AGs4zMaHluaGw65ux1hz9KzfC4j91xj4QSve4YzEsST0oD+rx/FEnG63vIXpm4YmlULqaCUWBECuAA== From: Dmitry Osipenko To: Felipe Balbi , Jonathan Hunter , Thierry Reding Cc: linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] usb: phy: tegra: Increase PHY clock stabilization timeout Date: Mon, 11 Dec 2017 01:55:35 +0300 Message-Id: <20171210225535.8532-1-digetx@gmail.com> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes "utmi_phy_clk_enable: timeout waiting for phy to stabilize" error message. Signed-off-by: Dmitry Osipenko --- drivers/usb/phy/phy-tegra-usb.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index f668bfb708d3..7d5db625f800 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/drivers/usb/phy/phy-tegra-usb.c @@ -16,7 +16,7 @@ #include #include #include -#include +#include #include #include #include @@ -305,14 +305,9 @@ static int utmip_pad_power_off(struct tegra_usb_phy *phy) static int utmi_wait_register(void __iomem *reg, u32 mask, u32 result) { - unsigned long timeout = 2000; - do { - if ((readl(reg) & mask) == result) - return 0; - udelay(1); - timeout--; - } while (timeout); - return -1; + u32 tmp; + + return readl_poll_timeout(reg, tmp, (tmp & mask) == result, 1, 5000); } static void utmi_phy_clk_disable(struct tegra_usb_phy *phy) -- 2.15.1