From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages Date: Mon, 11 Dec 2017 10:37:44 +0100 Message-ID: <20171211093744.GB10671@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0ntfKIWw70PvrIHh" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org --0ntfKIWw70PvrIHh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: > Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to > dev_err() and use common errors message formatting across the driver for > consistency. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++----------= ------ > 1 file changed, 44 insertions(+), 28 deletions(-) Can we also get rid of all the function names in error messages? I see that for some error messages you've removed them, but then for others you added them, so you remove inconsistencies on one hand and add other inconsistencies at the same time. =3D) Other than that, I like this. Thierry --0ntfKIWw70PvrIHh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlouUeUACgkQ3SOs138+ s6GhUQ//XStPco0+7j9QNrv3r3O5C7PE4snO+i3NnG5jSEsItSmpzxSWV6A8jnsr vPhLCGtjf0TAr2mEv/1fSNosJzN5cA4MZYgySQqLA9Iyeub9zTAk4eSWKgz8NVZj VodUv1NqESR66u5qP22TMOOFRNmuRNGzjdGl6d9343UewpPoVOtevBocme4+zbo2 9cMHN1Js/jXm3hdLcBzGAvySz9mI2bp2a9IINiei0mMg78uzefOB16ybvwmP58T2 T9Pfem/zJEknt8yBjxFR9EgKMBy6tcwFsN61jpm5Gcaj+oq20omwQL2wuqYuCrfP hRfrbdid4ZxO5wpiiM92nS1gYeKLwbopY0BtwF7bGbNGJpiaNiLiFeZ3yEaATeo/ 6bynf6AC0kZ5J74ZXN49EF99ajODQs25vN8e7bp1k+L4i2S17Ln2drkrNj+WOQ2q drsQiq0zzaiPIhzGAFvvOVreeIqubHSbC1KlkQ8nGcfgo++8gkBRAtcpFKXNFeeg UOilC9L5eTWauFLisHjeJSWuQ4tA0+sCEzFqgziTFuI7wOpHq0WqovnS2+xmsFMY u2mbPeB7xH0Gte9WhcYVHT4dkqUjs4d8EE0m3LTv1p1LFUokaYW77rpfG2q5J036 ROuvu95YcttBm8SqKjIEMj7I6Lv3pj0tEsNYrYqjl69REsKu8Qw= =yQ0J -----END PGP SIGNATURE----- --0ntfKIWw70PvrIHh-- -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/2] usb: phy: tegra: Cleanup error messages From: Thierry Reding Message-Id: <20171211093744.GB10671@ulmo> Date: Mon, 11 Dec 2017 10:37:44 +0100 To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDI6MDc6MzdBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IFRlZ3JhJ3MgUEhZIGRyaXZlciBoYXMgYSBtaXggb2YgcHJfZXJyKCkgYW5kIGRl dl9lcnIoKSwgbGV0J3Mgc3dpdGNoIHRvCj4gZGV2X2VycigpIGFuZCB1c2UgY29tbW9uIGVycm9y cyBtZXNzYWdlIGZvcm1hdHRpbmcgYWNyb3NzIHRoZSBkcml2ZXIgZm9yCj4gY29uc2lzdGVuY3ku Cj4gCj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL3VzYi9waHkvcGh5LXRlZ3JhLXVzYi5jIHwgNzIgKysrKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2Vy dGlvbnMoKyksIDI4IGRlbGV0aW9ucygtKQoKQ2FuIHdlIGFsc28gZ2V0IHJpZCBvZiBhbGwgdGhl IGZ1bmN0aW9uIG5hbWVzIGluIGVycm9yIG1lc3NhZ2VzPyBJIHNlZQp0aGF0IGZvciBzb21lIGVy cm9yIG1lc3NhZ2VzIHlvdSd2ZSByZW1vdmVkIHRoZW0sIGJ1dCB0aGVuIGZvciBvdGhlcnMKeW91 IGFkZGVkIHRoZW0sIHNvIHlvdSByZW1vdmUgaW5jb25zaXN0ZW5jaWVzIG9uIG9uZSBoYW5kIGFu ZCBhZGQgb3RoZXIKaW5jb25zaXN0ZW5jaWVzIGF0IHRoZSBzYW1lIHRpbWUuID0pCgpPdGhlciB0 aGFuIHRoYXQsIEkgbGlrZSB0aGlzLgoKVGhpZXJyeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752355AbdLKJhv (ORCPT ); Mon, 11 Dec 2017 04:37:51 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:34828 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdLKJhs (ORCPT ); Mon, 11 Dec 2017 04:37:48 -0500 X-Google-Smtp-Source: AGs4zMaIEpQvPSiW1ZArrDRBp52BKw9TMlynhyBhdY0vtcW8dCOqiV44A4u56T3iUXLZ8yQ8N00wzA== Date: Mon, 11 Dec 2017 10:37:44 +0100 From: Thierry Reding To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] usb: phy: tegra: Cleanup error messages Message-ID: <20171211093744.GB10671@ulmo> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0ntfKIWw70PvrIHh" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0ntfKIWw70PvrIHh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2017 at 02:07:37AM +0300, Dmitry Osipenko wrote: > Tegra's PHY driver has a mix of pr_err() and dev_err(), let's switch to > dev_err() and use common errors message formatting across the driver for > consistency. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/phy/phy-tegra-usb.c | 72 +++++++++++++++++++++++++----------= ------ > 1 file changed, 44 insertions(+), 28 deletions(-) Can we also get rid of all the function names in error messages? I see that for some error messages you've removed them, but then for others you added them, so you remove inconsistencies on one hand and add other inconsistencies at the same time. =3D) Other than that, I like this. Thierry --0ntfKIWw70PvrIHh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlouUeUACgkQ3SOs138+ s6GhUQ//XStPco0+7j9QNrv3r3O5C7PE4snO+i3NnG5jSEsItSmpzxSWV6A8jnsr vPhLCGtjf0TAr2mEv/1fSNosJzN5cA4MZYgySQqLA9Iyeub9zTAk4eSWKgz8NVZj VodUv1NqESR66u5qP22TMOOFRNmuRNGzjdGl6d9343UewpPoVOtevBocme4+zbo2 9cMHN1Js/jXm3hdLcBzGAvySz9mI2bp2a9IINiei0mMg78uzefOB16ybvwmP58T2 T9Pfem/zJEknt8yBjxFR9EgKMBy6tcwFsN61jpm5Gcaj+oq20omwQL2wuqYuCrfP hRfrbdid4ZxO5wpiiM92nS1gYeKLwbopY0BtwF7bGbNGJpiaNiLiFeZ3yEaATeo/ 6bynf6AC0kZ5J74ZXN49EF99ajODQs25vN8e7bp1k+L4i2S17Ln2drkrNj+WOQ2q drsQiq0zzaiPIhzGAFvvOVreeIqubHSbC1KlkQ8nGcfgo++8gkBRAtcpFKXNFeeg UOilC9L5eTWauFLisHjeJSWuQ4tA0+sCEzFqgziTFuI7wOpHq0WqovnS2+xmsFMY u2mbPeB7xH0Gte9WhcYVHT4dkqUjs4d8EE0m3LTv1p1LFUokaYW77rpfG2q5J036 ROuvu95YcttBm8SqKjIEMj7I6Lv3pj0tEsNYrYqjl69REsKu8Qw= =yQ0J -----END PGP SIGNATURE----- --0ntfKIWw70PvrIHh--