From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v1 2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig Date: Mon, 11 Dec 2017 11:04:00 +0100 Message-ID: <20171211100400.GE10671@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a1QUDc0q7S3U7/Jg" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-tegra@vger.kernel.org --a1QUDc0q7S3U7/Jg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 11, 2017 at 02:10:00AM +0300, Dmitry Osipenko wrote: > UDC driver won't probe without Tegra's PHY, hence select it in the > Kconfig. >=20 > Signed-off-by: Dmitry Osipenko > --- > drivers/usb/chipidea/Kconfig | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/usb/chipidea/Kconfig b/drivers/usb/chipidea/Kconfig > index 785f0ed037f7..2ef3b27ea72b 100644 > --- a/drivers/usb/chipidea/Kconfig > +++ b/drivers/usb/chipidea/Kconfig > @@ -27,6 +27,7 @@ config USB_CHIPIDEA_PCI > config USB_CHIPIDEA_UDC > bool "ChipIdea device controller" > depends on USB_GADGET > + select USB_TEGRA_PHY if ARCH_TEGRA This is kind of pointless given that USB_TEGRA_PHY originally was automatically enabled if ARCH_TEGRA was enabled. What do we gain by these two patches, other than maybe make the driver buildable as a module? Thierry --a1QUDc0q7S3U7/Jg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlouWBAACgkQ3SOs138+ s6Fmag/+KXeUWColoRE9PIwR/KKMmjhx/WZDiGTzDXP/D3TbZcUxRKJKzAoR2jd3 jbEDHlJNCnPfu0xOElBzooO+H5bMELiECKns6OVcQXTKkdk8AIhUlULJxb49nvFO bQxW5ztSUu4HlWD2DQqql8yavlYnOJUHKOhhXISkJvbgQiJ1YoxbYMxiKTAIU7tW sJgcE1foIfDXcj1WSfdO4U7rKUvxA9PsamPpyKGBIk7byKiayT/0uAF4fWzBItee uTLIPBr4EFLJPXjpROz6Wb7D0gFR5ldyekDigIqVHV1WF/QVvIUM5elAi5K4NIY5 X1eJNJMg08oFz3TR+zeSJU8cqPPKCA9rfuUnZo/09EjQiFumAZ+e/eXKX7prSNVW qK+V/MpKLO2UsICOIdXynTPi8m2uCxoJIZary1f0R+qA6R610kVXwzLI+Pz7DfGU J197dK7ZP7AVlaKipxXJRy79eva2GkkD7vMaJ+ulRGFM+gBHXkGvfV3zVcsAWXmL 4XMWYB8ZFRCifxHQZVaVIxfEsiqsJ3jsYCd0n03W3wNnqOullqVNzI5V18mjvHbr Dz2ScOa8Vq1/4pmTp+GnWcsEAceUbzTbOXsa78JWF0FUeR78I7k/6B7RvdKFKeH7 /9ATqpPbYl2QWeaZB4yryAiMlGDwU2bHm0gFGyTQHQKMj2PEOKA= =Cs+u -----END PGP SIGNATURE----- --a1QUDc0q7S3U7/Jg-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,2/2] usb: chipidea: tegra: Select Tegra's PHY in Kconfig From: Thierry Reding Message-Id: <20171211100400.GE10671@ulmo> Date: Mon, 11 Dec 2017 11:04:00 +0100 To: Dmitry Osipenko Cc: Felipe Balbi , Alan Stern , Greg Kroah-Hartman , Jonathan Hunter , Peter Chen , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDI6MTA6MDBBTSArMDMwMCwgRG1pdHJ5IE9zaXBlbmtv IHdyb3RlOgo+IFVEQyBkcml2ZXIgd29uJ3QgcHJvYmUgd2l0aG91dCBUZWdyYSdzIFBIWSwgaGVu Y2Ugc2VsZWN0IGl0IGluIHRoZQo+IEtjb25maWcuCj4gCj4gU2lnbmVkLW9mZi1ieTogRG1pdHJ5 IE9zaXBlbmtvIDxkaWdldHhAZ21haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3VzYi9jaGlwaWRl YS9LY29uZmlnIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jaGlwaWRlYS9LY29uZmlnIGIvZHJpdmVycy91c2IvY2hp cGlkZWEvS2NvbmZpZwo+IGluZGV4IDc4NWYwZWQwMzdmNy4uMmVmM2IyN2VhNzJiIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvdXNiL2NoaXBpZGVhL0tjb25maWcKPiArKysgYi9kcml2ZXJzL3VzYi9j aGlwaWRlYS9LY29uZmlnCj4gQEAgLTI3LDYgKzI3LDcgQEAgY29uZmlnIFVTQl9DSElQSURFQV9Q Q0kKPiAgY29uZmlnIFVTQl9DSElQSURFQV9VREMKPiAgCWJvb2wgIkNoaXBJZGVhIGRldmljZSBj b250cm9sbGVyIgo+ICAJZGVwZW5kcyBvbiBVU0JfR0FER0VUCj4gKwlzZWxlY3QgVVNCX1RFR1JB X1BIWSBpZiBBUkNIX1RFR1JBCgpUaGlzIGlzIGtpbmQgb2YgcG9pbnRsZXNzIGdpdmVuIHRoYXQg VVNCX1RFR1JBX1BIWSBvcmlnaW5hbGx5IHdhcwphdXRvbWF0aWNhbGx5IGVuYWJsZWQgaWYgQVJD SF9URUdSQSB3YXMgZW5hYmxlZC4KCldoYXQgZG8gd2UgZ2FpbiBieSB0aGVzZSB0d28gcGF0Y2hl cywgb3RoZXIgdGhhbiBtYXliZSBtYWtlIHRoZSBkcml2ZXIKYnVpbGRhYmxlIGFzIGEgbW9kdWxl PwoKVGhpZXJyeQo=