From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Date: Mon, 11 Dec 2017 15:20:23 +0200 Message-ID: <20171211132023.GO10981@intel.com> References: <20171208093323.2212-1-augustine.chen@intel.com> <20171208114404.GN10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Anand, Jerome" Cc: Juergen Gross , Dou Liyang , "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Jiang Liu , "Chen, Augustine" , "Bossart, Pierre-louis" List-Id: alsa-devel@alsa-project.org T24gTW9uLCBEZWMgMTEsIDIwMTcgYXQgMDg6MzM6MzNBTSArMDAwMCwgQW5hbmQsIEplcm9tZSB3 cm90ZToKPiAKPiAKPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiBGcm9tOiBUaG9t YXMgR2xlaXhuZXIgW21haWx0bzp0Z2x4QGxpbnV0cm9uaXguZGVdCj4gPiBTZW50OiBTYXR1cmRh eSwgRGVjZW1iZXIgOSwgMjAxNyA0OjIyIEFNCj4gPiBUbzogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBDaGVuLCBBdWd1c3RpbmUgPGF1Z3Vz dGluZS5jaGVuQGludGVsLmNvbT47IGludGVsLQo+ID4gZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZzsgYWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnOyBBbmFuZCwgSmVyb21lCj4gPiA8amVyb21l LmFuYW5kQGludGVsLmNvbT47IEJvc3NhcnQsIFBpZXJyZS1sb3VpcyA8cGllcnJlLQo+ID4gbG91 aXMuYm9zc2FydEBpbnRlbC5jb20+OyB0aXdhaUBzdXNlLmRlOyBJbmdvIE1vbG5hciA8bWluZ29A cmVkaGF0LmNvbT47Cj4gPiBILiBQZXRlciBBbnZpbiA8aHBhQHp5dG9yLmNvbT47IEppYW5nIExp dSA8amlhbmcubGl1QGxpbnV4LmludGVsLmNvbT47IEp1ZXJnZW4KPiA+IEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+OyBEb3UgTGl5YW5nIDxkb3VseS5mbnN0QGNuLmZ1aml0c3UuY29tPjsgbGludXgt Cj4gPiBrZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gPiBTdWJqZWN0OiBSZTogW0ludGVsLWdmeF0g W1BBVENIXSBkcm0vaTkxNTogUmVtb3ZlIHVudXNlZCBJUlEgY2hpcCBkYXRhIG9mCj4gPiBIRE1J IExQRSBhdWRpbwo+ID4gCj4gPiBPbiBGcmksIDggRGVjIDIwMTcsIFZpbGxlIFN5cmrDpGzDpCB3 cm90ZToKPiA+IAo+ID4gPiBPbiBGcmksIERlYyAwOCwgMjAxNyBhdCAwNTozMzoyM1BNICswODAw LCBBdWd1c3RpbmUuQ2hlbiB3cm90ZToKPiA+ID4gPiBUaGUgY2hpcCBkYXRhIG9mIEhETUkgTFBF IGF1ZGlvIGlzIHNldCB0byBkcm1faTkxNV9wcml2YXRlIHdoaWNoIGlzCj4gPiA+ID4gbm90IGNv bnNpc3RlbnQgd2l0aCB0aGUgZXhwZWN0YXRpb24gYnkgeDg2IEFQSUMgZHJpdmVyLgo+ID4gPgo+ ID4gPiBIbW0uIFdoeSBpcyB0aGUgYXBpYyBjb2RlIGxvb2tpbmcgYXQgZGF0YSBmb3IgYW4gaXJx IGNoaXAgaXQgaGFzbid0Cj4gPiA+IGNyZWF0ZWQ/Cj4gPiA+Cj4gCj4gYXBpYyBjb2RlIGV4cGVj dHMgYW4gaXJxIGRvbWFpbiB0byBiZSBwbGFjZSBhcyBnZW5lcmljIGFwcHJvYWNoLgo+IAo+ID4g PiBEbyB3ZSBuZWVkIHNvbWV0aGluZyBsaWtlCj4gPiA+IC0gZGV2X3ByaXYtPmxwZV9hdWRpby5p cnEgPSBpcnFfYWxsb2NfZGVzYygwKTsKPiA+ID4gKyBkZXZfcHJpdi0+bHBlX2F1ZGlvLmlycSA9 IGlycV9hbGxvY19kZXNjKC0xKTsKPiA+IAo+ID4gI2RlZmluZSBpcnFfYWxsb2NfZGVzYyhub2Rl KQo+ID4gCj4gPiBTbyBpbnN0ZWFkIG9mIGhhbmRpbmcgaW4gbm9kZSAwIHlvdSBoYW5kIGluIG5v ZGUgLTEgd2hpY2ggaXMgTlVNQV9OT19OT0RFCj4gPiAKCkFoLiBJIG1pc3JlYWQgdGhlIG1hY3Jv cy4gU28gd2UgYWxyZWFkeSBwYXNzIGlycT0tMS4KCj4gCj4gQWdyZWUgLSBhbSBub3Qgc3VyZSB3 aGV0aGVyIGl0IHdpbGwgbWFrZSBhbnkgZGlmZmVyZW5jZS4KPiAKPiA+ID4gVGhhdCAqbG9va3Mq IG1vcmUgY29ycmVjdCB0byBtZSBiYXNlZCBvbiBhIGN1cnNvcnkgZ2xhbmNlIGF0IHRoZSB4ODYK PiA+ID4gY29kZSwgYnV0IEkgZGlkbid0IHRyYXdsIHZlcnkgZGVlcGx5Lgo+ID4gCj4gPiBUaGUg eDg2IGNvcmUgY2FyZXMgbm90IGF0IGFsbCBhYm91dCBpbnRlcnJ1cHQgY2hpcHMgd2hpY2ggYXJl IGNyZWF0ZWQgaW4gYSBkcml2ZXIKPiA+IGFuZCBub3QgY29ubmVjdGVkIHRvIGFuIGFjdHVhbCBh cGljL2lvYXBpYy9tc2kgaW50ZXJydXB0LiBUaGlzIGludGVycnVwdCBjaGlwIGlzCj4gPiBpdHMg b3duIHRoaW5nIGFzIHdlIGhhdmUgb3RoZXJzIGluIEdQSU8gZXRjLgo+ID4gCj4gPiA+ID4gSW4g dGhlIGNhc2Ugb2Ygbm90IGVuYWJsaW5nIENPTkZJR19DUFVNQVNLX09GRlNUQUNLLCB0aGlzIHdv dWxkCj4gPiA+ID4gY2F1c2Uga2VybmVsIHBhbmljIHdoaWxlIGRvaW5nIENQVSBob3RwbHVnLgo+ ID4gCj4gPiBBbmQgd2h5IHNvPyBTdXJlbHkgbm90IGJlY2F1c2UgeW91IHNldCBpcnFfY2hpcF9k YXRhLiBUaGF0J3MgcmVhbGx5IG5vCj4gPiBleHBsYW5hdGlvbiBhdCBhbGwuCj4gPiAKPiAKPiBJ ZGVhbGx5LCBJIGZlZWwgdGhlcmUgbmVlZHMgdG8gYmUgYW4gaXJxIGRvbWFpbiBmb3IgbWFwcGlu ZyB0aGUgaXJxIG51bWJlcnMgd2l0aCBod2lycS4KPiBJdCBpcyBub3QgY3JlYXRlZCBhcyBwYXJ0 IG9mIHRoZSBoZG1pIGxwZSBhdWRpbyBicmlkZ2UuCj4gU2luY2UgdGhlIGxvZ2ljIHRvIG1hc2sv dW5tYXNrIGxwZSBhdWRpbyBpbnRlcnJ1cHRzIGlzIHJlbW92ZWQsIHRoZXJlIGlzIG5vIG5lZWQg b2YgdGhlCj4gQ2hpcCBkYXRhIG9yIGNyZWF0aW9uIG9mIHRoZSBkb21haW4gbm93LgoKVGhlcmUg aXMgbm8gbmVlZCByaWdodCBub3cuIEJ1dCB0aGVyZSBtaWdodCBiZSBhIG5lZWQgaW4gdGhlIGZ1 dHVyZS4KTFBFIGF1ZGlvIGlzbid0IGV2ZW4gdGhlIG9ubHkgcGllY2Ugb2YgaGFyZHdhcmUgd2hv c2UgaXJxIGdvZXMgdGhyb3VnaAp0aGUgaTkxNSBkaXNwbGF5IGVuZ2luZSAodGhlcmUncyBhbHNv IHRoZSBJU1AgYW5kIFZFRCkuIFNvIEkgd291bGQKbXVjaCBwcmVmZXIgYSBwcm9wZXIgc29sdXRp b24gaW5zdGVhZCBvZiBzd2VlcGluZyB0aGUgcHJvYmxlbSB1bmRlcgp0aGUgcnVnLgoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752836AbdLKNUc (ORCPT ); Mon, 11 Dec 2017 08:20:32 -0500 Received: from mga04.intel.com ([192.55.52.120]:16454 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbdLKNU3 (ORCPT ); Mon, 11 Dec 2017 08:20:29 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="10908413" Date: Mon, 11 Dec 2017 15:20:23 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Anand, Jerome" Cc: Thomas Gleixner , "Chen, Augustine" , "intel-gfx@lists.freedesktop.org" , "alsa-devel@alsa-project.org" , "Bossart, Pierre-louis" , "tiwai@suse.de" , Ingo Molnar , "H. Peter Anvin" , Jiang Liu , Juergen Gross , Dou Liyang , "linux-kernel@vger.kernel.org" Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Message-ID: <20171211132023.GO10981@intel.com> References: <20171208093323.2212-1-augustine.chen@intel.com> <20171208114404.GN10981@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 11, 2017 at 08:33:33AM +0000, Anand, Jerome wrote: > > > > -----Original Message----- > > From: Thomas Gleixner [mailto:tglx@linutronix.de] > > Sent: Saturday, December 9, 2017 4:22 AM > > To: Ville Syrjälä > > Cc: Chen, Augustine ; intel- > > gfx@lists.freedesktop.org; alsa-devel@alsa-project.org; Anand, Jerome > > ; Bossart, Pierre-louis > louis.bossart@intel.com>; tiwai@suse.de; Ingo Molnar ; > > H. Peter Anvin ; Jiang Liu ; Juergen > > Gross ; Dou Liyang ; linux- > > kernel@vger.kernel.org > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of > > HDMI LPE audio > > > > On Fri, 8 Dec 2017, Ville Syrjälä wrote: > > > > > On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote: > > > > The chip data of HDMI LPE audio is set to drm_i915_private which is > > > > not consistent with the expectation by x86 APIC driver. > > > > > > Hmm. Why is the apic code looking at data for an irq chip it hasn't > > > created? > > > > > apic code expects an irq domain to be place as generic approach. > > > > Do we need something like > > > - dev_priv->lpe_audio.irq = irq_alloc_desc(0); > > > + dev_priv->lpe_audio.irq = irq_alloc_desc(-1); > > > > #define irq_alloc_desc(node) > > > > So instead of handing in node 0 you hand in node -1 which is NUMA_NO_NODE > > Ah. I misread the macros. So we already pass irq=-1. > > Agree - am not sure whether it will make any difference. > > > > That *looks* more correct to me based on a cursory glance at the x86 > > > code, but I didn't trawl very deeply. > > > > The x86 core cares not at all about interrupt chips which are created in a driver > > and not connected to an actual apic/ioapic/msi interrupt. This interrupt chip is > > its own thing as we have others in GPIO etc. > > > > > > In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would > > > > cause kernel panic while doing CPU hotplug. > > > > And why so? Surely not because you set irq_chip_data. That's really no > > explanation at all. > > > > Ideally, I feel there needs to be an irq domain for mapping the irq numbers with hwirq. > It is not created as part of the hdmi lpe audio bridge. > Since the logic to mask/unmask lpe audio interrupts is removed, there is no need of the > Chip data or creation of the domain now. There is no need right now. But there might be a need in the future. LPE audio isn't even the only piece of hardware whose irq goes through the i915 display engine (there's also the ISP and VED). So I would much prefer a proper solution instead of sweeping the problem under the rug. -- Ville Syrjälä Intel OTC