Re: [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

[Tomasz Duszynski <tdu@semihalf.com>]

On Mon, Dec 11, 2017 at 12:44:43PM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, November 30, 2017 1:33 PM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; jck@semihalf.com; dima@marvell.com;
> > nsamsono@marvell.com; jianbo.liu@arm.com; Tomasz Duszynski
> > <tdu@semihalf.com>
> > Subject: [dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD
> > documentation
> >
> > Update MRVL CRYPTO PMD documentation.
> >
> > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>
>
> This is depending on the network driver update, right?
> You should say it in the cover letter. I will wait until it is applied then.

Right, I've missed that. Anyway, from what I see network driver
patches have been already applied.

>
> ...
>
> > -
> >  Installation
> >  ------------
> >
> > @@ -92,20 +85,11 @@ Currently there are two driver specific compilation
> > options in
> >
> >      Toggle display of debugging messages.
> >
> > -During compilation external MUSDK library, which provides direct access -
> > to Marvell's EIP197 cryptographic engine, is necessary. Library sources are -
> > available `here <https://github.com/MarvellEmbeddedProcessors/musdk-
> > marvell/tree/musdk-armada-17.08>`__.
> > +For a list of prerequisites please refer to `Prerequisites` section in
> > +:ref:`MRVL Poll Mode Driver <mrvl_poll_mode_driver>` guide.
>
> Maybe say that it is the network PMD?

OK. I'll send v2 then.

>
> Thanks,
> Pablo
>

--
- Tomasz Duszyński