diff for duplicates of <20171211141241.2129a84c.cohuck@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 74dd2ce..3a07a58 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -34,7 +34,7 @@ Christoffer Dall <cdall@kernel.org> wrote: > void __user *argp = (void __user *)arg; > long r; > -> + if (ioctl = KVM_INTERRUPT) { +> + if (ioctl == KVM_INTERRUPT) { I would add a comment here that this ioctl is async to vcpu execution, so it is understandable why you skip the vcpu_load(). @@ -68,7 +68,7 @@ the architectures' handlers.] > > - switch (ioctl) { > - case KVM_INTERRUPT: { -> + if (ioctl = KVM_INTERRUPT) { +> + if (ioctl == KVM_INTERRUPT) { Same here. diff --git a/a/content_digest b/N1/content_digest index 19d0e20..df573a5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020171204203538.8370-15-cdall@kernel.org\0" "From\0Cornelia Huck <cohuck@redhat.com>\0" "Subject\0Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" - "Date\0Mon, 11 Dec 2017 13:12:41 +0000\0" + "Date\0Mon, 11 Dec 2017 14:12:41 +0100\0" "To\0Christoffer Dall <cdall@kernel.org>" " Christian Borntraeger <borntraeger@de.ibm.com>\0" "Cc\0kvm@vger.kernel.org" @@ -56,7 +56,7 @@ "> \tvoid __user *argp = (void __user *)arg;\n" "> \tlong r;\n" "> \n" - "> +\tif (ioctl = KVM_INTERRUPT) {\n" + "> +\tif (ioctl == KVM_INTERRUPT) {\n" "\n" "I would add a comment here that this ioctl is async to vcpu execution,\n" "so it is understandable why you skip the vcpu_load().\n" @@ -90,7 +90,7 @@ "> \n" "> -\tswitch (ioctl) {\n" "> -\tcase KVM_INTERRUPT: {\n" - "> +\tif (ioctl = KVM_INTERRUPT) {\n" + "> +\tif (ioctl == KVM_INTERRUPT) {\n" "\n" "Same here.\n" "\n" @@ -194,4 +194,4 @@ "mutex for special cases (and not releasing it for those special cases),\n" I don't see an elegant way to do that. -111eb2a403d265914cca4d867f03dd3d870ad44b11a4ca64c305c517a0744ff1 +638969cf5ee1037a38e1c1f2ddc0d48562034fd35333aee42cbdb8fdd6b5b880
diff --git a/a/1.txt b/N2/1.txt index 74dd2ce..3a07a58 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -34,7 +34,7 @@ Christoffer Dall <cdall@kernel.org> wrote: > void __user *argp = (void __user *)arg; > long r; > -> + if (ioctl = KVM_INTERRUPT) { +> + if (ioctl == KVM_INTERRUPT) { I would add a comment here that this ioctl is async to vcpu execution, so it is understandable why you skip the vcpu_load(). @@ -68,7 +68,7 @@ the architectures' handlers.] > > - switch (ioctl) { > - case KVM_INTERRUPT: { -> + if (ioctl = KVM_INTERRUPT) { +> + if (ioctl == KVM_INTERRUPT) { Same here. diff --git a/a/content_digest b/N2/content_digest index 19d0e20..6620f38 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,9 @@ "ref\020171204203538.8370-1-cdall@kernel.org\0" "ref\020171204203538.8370-15-cdall@kernel.org\0" - "From\0Cornelia Huck <cohuck@redhat.com>\0" - "Subject\0Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" - "Date\0Mon, 11 Dec 2017 13:12:41 +0000\0" - "To\0Christoffer Dall <cdall@kernel.org>" - " Christian Borntraeger <borntraeger@de.ibm.com>\0" - "Cc\0kvm@vger.kernel.org" - Andrew Jones <drjones@redhat.com> - Christoffer Dall <christoffer.dall@linaro.org> - Paolo Bonzini <pbonzini@redhat.com> - " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <marc.zyngier@arm.com> - kvmarm@lists.cs.columbia.edu - linux-arm-kernel@lists.infradead.org - James Hogan <jhogan@kernel.org> - linux-mips@linux-mips.org - Paul Mackerras <paulus@ozlabs.org> - kvm-ppc@vger.kernel.org - " linux-s390@vger.kernel.org\0" + "From\0cohuck@redhat.com (Cornelia Huck)\0" + "Subject\0[PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" + "Date\0Mon, 11 Dec 2017 14:12:41 +0100\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Mon, 4 Dec 2017 21:35:36 +0100\n" @@ -56,7 +42,7 @@ "> \tvoid __user *argp = (void __user *)arg;\n" "> \tlong r;\n" "> \n" - "> +\tif (ioctl = KVM_INTERRUPT) {\n" + "> +\tif (ioctl == KVM_INTERRUPT) {\n" "\n" "I would add a comment here that this ioctl is async to vcpu execution,\n" "so it is understandable why you skip the vcpu_load().\n" @@ -90,7 +76,7 @@ "> \n" "> -\tswitch (ioctl) {\n" "> -\tcase KVM_INTERRUPT: {\n" - "> +\tif (ioctl = KVM_INTERRUPT) {\n" + "> +\tif (ioctl == KVM_INTERRUPT) {\n" "\n" "Same here.\n" "\n" @@ -194,4 +180,4 @@ "mutex for special cases (and not releasing it for those special cases),\n" I don't see an elegant way to do that. -111eb2a403d265914cca4d867f03dd3d870ad44b11a4ca64c305c517a0744ff1 +e5d2d412dfc1e2ffb72facf54938002eb3a698469c77a20c6d131521e55c1c0e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.