diff for duplicates of <20171211152226.GJ910@cbox> diff --git a/a/1.txt b/N1/1.txt index a9e9052..50e5a2f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -35,7 +35,7 @@ On Mon, Dec 11, 2017 at 02:12:41PM +0100, Cornelia Huck wrote: > > void __user *argp = (void __user *)arg; > > long r; > > -> > + if (ioctl = KVM_INTERRUPT) { +> > + if (ioctl == KVM_INTERRUPT) { > > I would add a comment here that this ioctl is async to vcpu execution, > so it is understandable why you skip the vcpu_load(). @@ -75,7 +75,7 @@ Agreed. > > > > - switch (ioctl) { > > - case KVM_INTERRUPT: { -> > + if (ioctl = KVM_INTERRUPT) { +> > + if (ioctl == KVM_INTERRUPT) { > > Same here. > diff --git a/a/content_digest b/N1/content_digest index 2150729..d695c34 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020171211141241.2129a84c.cohuck@redhat.com\0" "From\0Christoffer Dall <christoffer.dall@linaro.org>\0" "Subject\0Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" - "Date\0Mon, 11 Dec 2017 15:22:26 +0000\0" + "Date\0Mon, 11 Dec 2017 16:22:26 +0100\0" "To\0Cornelia Huck <cohuck@redhat.com>\0" "Cc\0Christoffer Dall <cdall@kernel.org>" Christian Borntraeger <borntraeger@de.ibm.com> @@ -58,7 +58,7 @@ "> > \tvoid __user *argp = (void __user *)arg;\n" "> > \tlong r;\n" "> > \n" - "> > +\tif (ioctl = KVM_INTERRUPT) {\n" + "> > +\tif (ioctl == KVM_INTERRUPT) {\n" "> \n" "> I would add a comment here that this ioctl is async to vcpu execution,\n" "> so it is understandable why you skip the vcpu_load().\n" @@ -98,7 +98,7 @@ "> > \n" "> > -\tswitch (ioctl) {\n" "> > -\tcase KVM_INTERRUPT: {\n" - "> > +\tif (ioctl = KVM_INTERRUPT) {\n" + "> > +\tif (ioctl == KVM_INTERRUPT) {\n" "> \n" "> Same here.\n" "> \n" @@ -210,4 +210,4 @@ "Thanks,\n" -Christoffer -d4bfd2976667ada9c4e1d8ec158b3f0a253704604942e78fca5ebe05b4f54587 +cf09a0eab2a1aa8e0f1509f0b40fa38dd3fe455067f01fb695150295cac9d309
diff --git a/a/1.txt b/N2/1.txt index a9e9052..50e5a2f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -35,7 +35,7 @@ On Mon, Dec 11, 2017 at 02:12:41PM +0100, Cornelia Huck wrote: > > void __user *argp = (void __user *)arg; > > long r; > > -> > + if (ioctl = KVM_INTERRUPT) { +> > + if (ioctl == KVM_INTERRUPT) { > > I would add a comment here that this ioctl is async to vcpu execution, > so it is understandable why you skip the vcpu_load(). @@ -75,7 +75,7 @@ Agreed. > > > > - switch (ioctl) { > > - case KVM_INTERRUPT: { -> > + if (ioctl = KVM_INTERRUPT) { +> > + if (ioctl == KVM_INTERRUPT) { > > Same here. > diff --git a/a/content_digest b/N2/content_digest index 2150729..47d8574 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,24 +1,10 @@ "ref\020171204203538.8370-1-cdall@kernel.org\0" "ref\020171204203538.8370-15-cdall@kernel.org\0" "ref\020171211141241.2129a84c.cohuck@redhat.com\0" - "From\0Christoffer Dall <christoffer.dall@linaro.org>\0" - "Subject\0Re: [PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" - "Date\0Mon, 11 Dec 2017 15:22:26 +0000\0" - "To\0Cornelia Huck <cohuck@redhat.com>\0" - "Cc\0Christoffer Dall <cdall@kernel.org>" - Christian Borntraeger <borntraeger@de.ibm.com> - kvm@vger.kernel.org - Andrew Jones <drjones@redhat.com> - Paolo Bonzini <pbonzini@redhat.com> - " Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Marc Zyngier <marc.zyngier@arm.com> - kvmarm@lists.cs.columbia.edu - linux-arm-kernel@lists.infradead.org - James Hogan <jhogan@kernel.org> - linux-mips@linux-mips.org - Paul Mackerras <paulus@ozlabs.org> - kvm-ppc@vger.kernel.org - " linux-s390@vger.kernel.org\0" + "From\0christoffer.dall@linaro.org (Christoffer Dall)\0" + "Subject\0[PATCH v3 14/16] KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl\0" + "Date\0Mon, 11 Dec 2017 16:22:26 +0100\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Mon, Dec 11, 2017 at 02:12:41PM +0100, Cornelia Huck wrote:\n" @@ -58,7 +44,7 @@ "> > \tvoid __user *argp = (void __user *)arg;\n" "> > \tlong r;\n" "> > \n" - "> > +\tif (ioctl = KVM_INTERRUPT) {\n" + "> > +\tif (ioctl == KVM_INTERRUPT) {\n" "> \n" "> I would add a comment here that this ioctl is async to vcpu execution,\n" "> so it is understandable why you skip the vcpu_load().\n" @@ -98,7 +84,7 @@ "> > \n" "> > -\tswitch (ioctl) {\n" "> > -\tcase KVM_INTERRUPT: {\n" - "> > +\tif (ioctl = KVM_INTERRUPT) {\n" + "> > +\tif (ioctl == KVM_INTERRUPT) {\n" "> \n" "> Same here.\n" "> \n" @@ -210,4 +196,4 @@ "Thanks,\n" -Christoffer -d4bfd2976667ada9c4e1d8ec158b3f0a253704604942e78fca5ebe05b4f54587 +fe98e4a4c2b61cd55abf60efc434594d38e35a4fadb6e2ab77c41079cd86d7e2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.