From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net v2 4/9] net: aquantia: Fill ndev stat couters from
 hardware
Date: Mon, 11 Dec 2017 16:47:57 +0100
Message-ID: <20171211154757.GJ28672@lunn.ch>
References: <cover.1512994559.git.igor.russkikh@aquantia.com>
 <2a99c143ef60ccd48c2720c1a9ad57222f37952e.1512994559.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        David Arcari <darcari@redhat.com>,
        Pavel Belous <pavel.belous@aquantia.com>,
        Nadezhda Krupnina <Nadezhda.Krupnina@aquantia.com>,
        Simon Edelhaus <simon.edelhaus@aquantia.com>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:56977 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751956AbdLKPr6 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 11 Dec 2017 10:47:58 -0500
Content-Disposition: inline
In-Reply-To: <2a99c143ef60ccd48c2720c1a9ad57222f37952e.1512994559.git.igor.russkikh@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, Dec 11, 2017 at 03:16:21PM +0300, Igor Russkikh wrote:
> Originally they were filled from ring sw counters.
> These sometimes incorrectly calculate byte and packet amounts
> when using LRO/LSO and jumboframes. Filling ndev counters from
> hardware makes them precise.
> 
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew