From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/brk: limit the largest requesting memory to UINT_MAX
Date: Mon, 11 Dec 2017 16:48:06 +0100 [thread overview]
Message-ID: <20171211154806.GC12716@rei> (raw)
In-Reply-To: <1508902611-28530-2-git-send-email-lizhijian@cn.fujitsu.com>
Hi!
> sometimes(some platforms), sbrk(0) will return a huge address(e.g
> Beg_brk_val=94392102215680), it will lead to the request a huge
> memory by brk(size>1T) which beyonds most host memory size
I think that the code in the setup that determines the Max_brk_byte_size
does not make any sense to me, it seems to just multiply random value
(the initial break addres) by 4 and uses that as a base for increment. I
guess that it would be much better if we just choosen some multiple of
page size for the test.
Also the test should be running several iterations but we run only one
by default.
All in all I think that it would be much better if we rewrote the test
from scratch using the new test library instead of applying band aids
to problems that are broken by design.
In short, do you want to take on rewriting the test or should I do that?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2017-12-11 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 3:36 [LTP] [PATCH 1/2] syscalls/brk: change to unsigned long to avoid incr overflow Li Zhijian
2017-10-25 3:36 ` [LTP] [PATCH 2/2] syscalls/brk: limit the largest requesting memory to UINT_MAX Li Zhijian
2017-12-11 15:48 ` Cyril Hrubis [this message]
2017-12-12 2:56 ` Li Zhijian
-- strict thread matches above, loose matches on Subject: below --
2017-10-25 3:33 [LTP] [PATCH 1/2] syscalls/brk: change to unsigned long to avoid incr overflow Li Zhijian
2017-10-25 3:33 ` [LTP] [PATCH 2/2] syscalls/brk: limit the largest requesting memory to UINT_MAX Li Zhijian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211154806.GC12716@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.