From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net v2 7/9] net: aquantia: Reset driver level statistics to zero on initialization Date: Mon, 11 Dec 2017 16:51:56 +0100 Message-ID: <20171211155156.GK28672@lunn.ch> References: <99425adad58a8ed133edc1a2b5ec8fec70e56e36.1512994559.git.igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , netdev@vger.kernel.org, David Arcari , Pavel Belous , Nadezhda Krupnina , Simon Edelhaus To: Igor Russkikh Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:56984 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbdLKPv7 (ORCPT ); Mon, 11 Dec 2017 10:51:59 -0500 Content-Disposition: inline In-Reply-To: <99425adad58a8ed133edc1a2b5ec8fec70e56e36.1512994559.git.igor.russkikh@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: > --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c > +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c > @@ -344,6 +344,13 @@ static int hw_atl_a0_hw_init(struct aq_hw_s *self, > hw_atl_a0_hw_rss_set(self, &aq_nic_cfg->aq_rss); > hw_atl_a0_hw_rss_hash_set(self, &aq_nic_cfg->aq_rss); > > + /* Read initial hardware counters > + * and reset current in-driver statistics > + */ > + hw_atl_utils_update_stats(self); > + memset(&PHAL_ATLANTIC_A0->curr_stats, 0, > + sizeof(PHAL_ATLANTIC_A0->curr_stats)); > + > err = aq_hw_err_from_flags(self); > if (err < 0) > goto err_exit; Hi Igor It looks like this is called on pm state change? Does this mean that resume will zero the statistics? That is probably not what you want. You should probably only clear the statics in the probe function. Andrew