All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Cengiz Can <cengizc@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: update i2c-dev.h warning in documentation
Date: Mon, 11 Dec 2017 16:20:04 -0700	[thread overview]
Message-ID: <20171211162004.2185a7ef@lwn.net> (raw)
In-Reply-To: <20171209231058.270ce75c@nostromo>

On Sat, 9 Dec 2017 23:10:58 +0300
Cengiz Can <cengizc@gmail.com> wrote:

> `dev-interface` document gives examples for accessing i2c from
> userspace.
> 
> There's a note warning developers about the different `i2c-dev.h` header
> files which were shipped with the kernel and i2c-tools separately.
> 
> However, these commits in i2c-tools repository suggests that the header
> files are now identical (in functionality) and `i2c_*` functions are now
> defined in a separate header called `i2c/smbus.h`, which is distributed
> with i2c-tools:
> 
> commit 652619121974 ("Minimize differences with kernel flavor")
> commit 93caf007f4cb ("Move SMBus helper functions to include/i2c/smbus.h")
> 
> Thus, I've converted the warning paragraph into a historical note and
> updated the suggested header files.
> 
> Signed-off-by: Cengiz Can <cengizc@gmail.com>

So this seems like a worthwhile change, but the patch contains a number of
unrelated changes, mostly white-space stuff it seems.  Can you clean that
up and resend?

Thanks,

jon

  reply	other threads:[~2017-12-11 23:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-09 20:10 [PATCH] i2c: update i2c-dev.h warning in documentation Cengiz Can
2017-12-11 23:20 ` Jonathan Corbet [this message]
2017-12-12 16:43   ` [PATCH v2] " Cengiz C.
2017-12-21 19:38     ` Jonathan Corbet
2017-12-21 20:49       ` Cengiz Can
2017-12-21 20:54         ` Jonathan Corbet
  -- strict thread matches above, loose matches on Subject: below --
2017-12-09 19:59 [PATCH] " Cengiz Can

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211162004.2185a7ef@lwn.net \
    --to=corbet@lwn.net \
    --cc=cengizc@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.