All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Roger Quadros <rogerq@ti.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2
Date: Mon, 11 Dec 2017 08:47:31 -0800	[thread overview]
Message-ID: <20171211164731.GL24344@atomide.com> (raw)
In-Reply-To: <87r2sau3fo.fsf@linux.intel.com>

* Felipe Balbi <balbi@kernel.org> [171204 11:43]:
> Roger Quadros <rogerq@ti.com> writes:
> 
> > The metastability workaround causes Erratic errors [1]
> > on the HighSpeed USB PHY which can cause upto 2 seconds
> > delay in enumerating to a USB host while in Gadget mode.
> >
> > Disable the Run/Stop metastability workaround to avoid this
> > ill effect. We are aware that this opens up the opportunity
> > for Run/Stop metastability, however this issue has never been
> > observed in TI releases so we think that Run/Stop metastability
> > is a lesser evil than the PHY Erratic errors. So disable it.
> >
> > [1] USB controller trace during gadget enumeration
> >     irq/90-dwc3-969   [000] d...    52.323145: dwc3_event: event (00000901): Erratic Error [U0]
> >     irq/90-dwc3-969   [000] d...    52.560646: dwc3_event: event (00000901): Erratic Error [U0]
> >     irq/90-dwc3-969   [000] d...    52.798144: dwc3_event: event (00000901): Erratic Error [U0]
> >
> > Signed-off-by: Roger Quadros <rogerq@ti.com>
> 
> FWIW:
> 
> Acked-by: Felipe Balbi <felipe.balbi@linux/intel.com>
> 
> I'm taking the dwc3 counterpart to v4.16

OK applying this into omap-for-v4.16/dt thanks.

Tony

      reply	other threads:[~2017-12-11 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 13:26 [PATCH] ARM: dts: dra7: Disable USB metastability workaround for USB2 Roger Quadros
2017-10-31 13:26 ` Roger Quadros
2017-12-04 11:40 ` Felipe Balbi
2017-12-04 11:40   ` Felipe Balbi
2017-12-11 16:47   ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211164731.GL24344@atomide.com \
    --to=tony@atomide.com \
    --cc=balbi@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.